-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version-validation for GO 1.13 (go-macaron/cors) #8389
Merged
techknowlogick
merged 3 commits into
go-gitea:release/v1.9
from
6543-forks:fix-go-dependency_macaron-cors
Oct 6, 2019
Merged
Fix version-validation for GO 1.13 (go-macaron/cors) #8389
techknowlogick
merged 3 commits into
go-gitea:release/v1.9
from
6543-forks:fix-go-dependency_macaron-cors
Oct 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
force-pushed
the
fix-go-dependency_macaron-cors
branch
from
October 6, 2019 03:17
7e30999
to
d18ba45
Compare
Note for maintainers reviewing: This has been solved for gitea 1.10, however as we changed the upstream dependency we couldn't backport. This will allow 1.9.4 to be built with golang 1.13 |
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Oct 6, 2019
@6543 please update vendor/modules.txt as well |
6543
changed the title
fix version-validation (because of 1.12 -> 1.13 switch)
WIP: fix version-validation (because of 1.12 -> 1.13 switch)
Oct 6, 2019
nvm. I was looking at an old CI build |
6543
changed the title
WIP: fix version-validation (because of 1.12 -> 1.13 switch)
fix version-validation (because of 1.12 -> 1.13 switch)
Oct 6, 2019
build was succesfull!! |
@techknowlogick works 🗡️ |
techknowlogick
approved these changes
Oct 6, 2019
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Oct 6, 2019
guillep2k
approved these changes
Oct 6, 2019
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Oct 6, 2019
CI done |
now we can build 1.9.x with new fixes ... |
6543
changed the title
fix version-validation (because of 1.12 -> 1.13 switch)
Fix version-validation for GO 1.13 (go-macaron/cors)
Oct 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tip.golang.org/doc/go1.13#version-validation
will solve #8387