Add support for X-Hub-Signature headers in webhooks #8473
Conversation
| @@ -572,7 +574,8 @@ type HookTask struct { | |||
| UUID string | |||
| Type HookTaskType | |||
| URL string `xorm:"TEXT"` | |||
| Signature string `xorm:"TEXT"` | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
GiteaBot
added
the
lgtm/need 2
| var err error | ||
|
|
||
| switch x.Dialect().DriverName() { | ||
| case "mysql": |
There was a problem hiding this comment.
Two things. 1. Rename columns is tricky (for example SQLite also needs to be added to this migration) so perhaps instead of a rename we keep signature column with same content we just have the strict field be renamed, and then add the new sha column. 2. Could you add the adding of the new column to this migration, while it is added by the default migration,sometimes we’ve been bitten by changing a column that doesn’t yet exist so usually we request explicit add of new columns.
Apologies if I am unclear, I am on mobile and can give better details when I get to a computer. Please ask any questions.
| @@ -572,7 +574,8 @@ type HookTask struct { | |||
| UUID string | |||
| Type HookTaskType | |||
| URL string `xorm:"TEXT"` | |||
| Signature string `xorm:"TEXT"` | |||
| SignatureSha1 string `xorm:"TEXT"` | |||
There was a problem hiding this comment.
| SignatureSha1 string `xorm:"TEXT"` | |
| Signature string `xorm:"TEXT"` |
models/webhook.go
Outdated
| @@ -572,7 +574,8 @@ type HookTask struct { | |||
| UUID string | |||
| Type HookTaskType | |||
| URL string `xorm:"TEXT"` | |||
| Signature string `xorm:"TEXT"` | |||
| SignatureSha1 string `xorm:"TEXT"` | |||
| SignatureSha256 string `xorm:"TEXT"` | |||
There was a problem hiding this comment.
| SignatureSha256 string `xorm:"TEXT"` | |
| SignatureSha1 string `xorm:"TEXT"` |
There was a problem hiding this comment.
There still needs to be fields:
Signature string `xorm:"TEXT"`
SignatureSha1 string `xorm:"TEXT"`
Co-Authored-By: Lauris BH <lauris@nix.lv>
Co-Authored-By: Lauris BH <lauris@nix.lv>
|
I would like @lafriks 's change. So that your migrations will be simpler to only use |
|
Please resolve the conflicts. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
|
This pull request has been automatically closed because of inactivity. You can re-open it if needed. |
Send a new header X-Hub-Signature using the sha1 format
Renames existing Signature to Signature256 since we need to generate to HMACs from the same secret
Fix #7788