WIP: Add keyboard accessibility to gitea #8555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit of a workaround, but it saves editing a ton of HTML for now.
This signals to Orca to send keydown events for all keys, so now Orca's caret mode will properly allow navigation through menus.
This makes the 'create organization' link keyboard accessible
The actual non-minified diff looks like this:
--- semantic.js.bak 2019-10-17 12:12:06.027276089 +1100
+++ semantic.js 2019-10-17 13:25:31.702478323 +1100
@@ -5613,6 +5613,7 @@
module.set.scrollPosition($choice);
}
+ this.click();
module.determine.selectAction.call(this, text, value);
}
}
},
|
I'm unsure about the last commit since it doesn't fix cases where dropdown menus are used as visual indicators (accordian UIs) mostly, and can't be clicked by the UI. I think I need to dig a bit deeper on that. |
GiteaBot
added
the
lgtm/need 2
|
I'm going to close this for now and split this up in to smaller patches. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the discussion for this is in https://github.com/go-gitea/gitea#7057 , but this patch set does a few things:
Currently this is done using jQuery code when loading the document, but ideally most of this would be edits of the template code once this is confirmed to not break things.
This also edits the semantic UI code which is minified, though I provide a diff of the source code in the commit message. I'm also unsure if #3 should be included right now or left for a screen reader WIP.
I have only tested this manually using Firefox 69 on Ubuntu 19.04 with Orca master, so testing to see if this breaks anything would be great.