Batch updates for issues #926

ethantkoenig · 2017-02-14T01:09:58Z

#868

Updates the

:reponame/issues/:index/label
:reponame/issues/:index/milestone
:reponame/issues/:index/assignee

endpoints to allow for multiple issues.

Also adds a front-end for opening/closing/assigning/labelling/milestoning multiple issues at once.

I am by no means a front-end expert, so any feedback is welcome 😄

bkcsoft · 2017-02-14T22:39:49Z

I don't like having Add Label and Remove Label split... Otherwise I have no comments on the design, L-G-T-M :)

bkcsoft

Please don't do this 😢

bkcsoft · 2017-02-14T22:40:47Z

routers/repo/issue.go

-		return
-	}
+// UpdateIssues perform update on collection of issues
+func UpdateIssues(ctx *context.Context) {


Ooh god please no 😱

So do you want

separate functions for milestones/labels/assignees, each of which can handle both a single or multiple issues?

keep the pre-existing functions milestones/labels/assignees (which can only handle a single issue), and introduce 3 new milestones/labels/assignees for multiple issues?

Also, what is wrong with what I did? I don't mean to argue, I just want to learn.

Preferably the first one. I'm not read up on the specific functions to give any advice, but I could have a look sometime during the week if you need pointers 🙂

The part that was wrong (in my opinion), was taking 3 small and clean functions, and turning them into one huge, hard to read switch-statement 🙂

ethantkoenig · 2017-02-15T20:41:15Z

@bkcsoft I have addressed your concerns (combine Add Labels and Remove Labels menus, split UpdateIssues back into multiple functions)

andreynering

Just two little sintax issues.

andreynering · 2017-02-18T15:40:40Z

public/js/index.js

+        "_csrf": csrf,
+        "action": action,
+        "issue_ids": issueIds,
+        "id": elementId


Missing indentation of data object

andreynering · 2017-02-18T15:43:13Z

public/js/index.js

@@ -119,13 +125,15 @@ function initCommentForm() {
            $(this).removeClass('checked');
            $(this).find('.octicon').removeClass('octicon-check');
            if (hasLabelUpdateAction) {
-                updateIssueMeta($labelMenu.data('update-url'), "detach", $(this).data('id'));
+                updateIssuesMeta($labelMenu.data('update-url'), "detach",
+                    $labelMenu.data('issue-id'), $(this).data('id'));


I think, or keep function call on a single line, or keep each param in a line, like this:

updateIssuesMeta( $labelMenu.data('update-url'), "detach", $labelMenu.data('issue-id'), $(this).data('id') );

Same for similar cases below.

andreynering · 2017-02-18T15:47:26Z

Useful feature. LGTM

Ref: gogs/gogs#2049

ethantkoenig · 2017-03-01T13:49:25Z

Rebasing to resolve conflicts.

lunny · 2017-03-10T06:33:16Z

conflicted.

ethantkoenig · 2017-03-10T18:46:49Z

Rebased.

lunny · 2017-03-11T03:01:52Z

routers/repo/issue.go

+	if len(commaSeparatedIssueIDs) == 0 {
+		return nil
+	}
+	stringIssueIDs := strings.Split(commaSeparatedIssueIDs, ",")


Why not use x.In().Find()? It's better performance?

lunny · 2017-03-11T03:05:07Z

routers/repo/issue.go

+		log.Warn("Unrecognized action: %s", action)
+	}
+
+	for _, issue := range issues {


IssueList(issues).LoadRepositories()

lunny · 2017-03-11T03:18:23Z

otherwise LGTM

ethantkoenig · 2017-03-11T17:42:55Z

@bkcsoft I've addressed your concerns from a few weeks ago; please re-review when you get the chance 😄

lunny · 2017-03-13T01:48:00Z

but seems you changed index.css file and not index.less ?

ethantkoenig · 2017-03-13T01:48:54Z

Oh, didn't realize there was a .less file. Will update.

ethantkoenig · 2017-03-13T17:20:16Z

@lunny Updated to use _repository.less.

lunny · 2017-03-14T01:13:48Z

build failed and need @bkcsoft confirmation.

bkcsoft · 2017-03-15T01:10:06Z

LGTM

lunny added this to the 1.2.0 milestone Feb 14, 2017

lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 14, 2017

ethantkoenig force-pushed the actions_on_issues branch 2 times, most recently from b5b37a4 to 89c354b Compare February 14, 2017 01:42

tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 14, 2017

bkcsoft suggested changes Feb 14, 2017

View reviewed changes

ethantkoenig force-pushed the actions_on_issues branch 4 times, most recently from 08ab657 to a422be7 Compare February 15, 2017 20:34

andreynering approved these changes Feb 18, 2017

View reviewed changes

tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 18, 2017

This was referenced Feb 21, 2017

New Release unfoldingWord/dcs#154

Closed

Merge Updates from Upstream unfoldingWord/dcs#153

Closed

ethantkoenig force-pushed the actions_on_issues branch from d566013 to 395e9cc Compare March 1, 2017 13:49

ethantkoenig force-pushed the actions_on_issues branch from 395e9cc to b168e75 Compare March 1, 2017 13:49

ethantkoenig force-pushed the actions_on_issues branch from b168e75 to 92fa9ea Compare March 10, 2017 14:22

lunny reviewed Mar 11, 2017

View reviewed changes

tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 11, 2017

ethantkoenig force-pushed the actions_on_issues branch from b72d61f to 43af73b Compare March 11, 2017 17:43

ethantkoenig force-pushed the actions_on_issues branch from 393b30b to 230c903 Compare March 14, 2017 01:34

ethantkoenig added 3 commits March 13, 2017 22:31

Batch updates for issues

ceb6cc3

Efficiency improvements

49dbbb1

Update _repository.less

0d2a991

ethantkoenig force-pushed the actions_on_issues branch from 230c903 to 0d2a991 Compare March 14, 2017 02:31

bkcsoft approved these changes Mar 15, 2017

View reviewed changes

bkcsoft merged commit 09fe4a2 into go-gitea:master Mar 15, 2017

ethantkoenig deleted the actions_on_issues branch March 15, 2017 01:10

lunny mentioned this pull request Apr 19, 2017

Easier-to-perform actions on issues #868

Closed

ethantkoenig added a commit to ethantkoenig/gitea that referenced this pull request Apr 29, 2017

Batch updates for issues (go-gitea#926)

ccff0ec

go-gitea locked and limited conversation to collaborators Nov 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Batch updates for issues #926

Batch updates for issues #926

ethantkoenig commented Feb 14, 2017 •

edited

Loading

bkcsoft commented Feb 14, 2017 •

edited

Loading

bkcsoft left a comment

bkcsoft Feb 14, 2017

ethantkoenig Feb 15, 2017

bkcsoft Feb 15, 2017

ethantkoenig commented Feb 15, 2017

andreynering left a comment

andreynering Feb 18, 2017

andreynering Feb 18, 2017

andreynering commented Feb 18, 2017

ethantkoenig commented Mar 1, 2017 •

edited

Loading

lunny commented Mar 10, 2017

ethantkoenig commented Mar 10, 2017

lunny Mar 11, 2017 •

edited

Loading

ethantkoenig Mar 11, 2017

lunny Mar 11, 2017

ethantkoenig Mar 11, 2017

lunny commented Mar 11, 2017

ethantkoenig commented Mar 11, 2017

lunny commented Mar 13, 2017

ethantkoenig commented Mar 13, 2017

ethantkoenig commented Mar 13, 2017

lunny commented Mar 14, 2017

bkcsoft commented Mar 15, 2017

Batch updates for issues #926

Batch updates for issues #926

Conversation

ethantkoenig commented Feb 14, 2017 • edited Loading

bkcsoft commented Feb 14, 2017 • edited Loading

bkcsoft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ethantkoenig commented Feb 15, 2017

andreynering left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreynering commented Feb 18, 2017

ethantkoenig commented Mar 1, 2017 • edited Loading

lunny commented Mar 10, 2017

ethantkoenig commented Mar 10, 2017

lunny Mar 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lunny commented Mar 11, 2017

ethantkoenig commented Mar 11, 2017

lunny commented Mar 13, 2017

ethantkoenig commented Mar 13, 2017

ethantkoenig commented Mar 13, 2017

lunny commented Mar 14, 2017

bkcsoft commented Mar 15, 2017

ethantkoenig commented Feb 14, 2017 •

edited

Loading

bkcsoft commented Feb 14, 2017 •

edited

Loading

ethantkoenig commented Mar 1, 2017 •

edited

Loading

lunny Mar 11, 2017 •

edited

Loading