-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove release attachments which repository has been deleted #9334
Merged
techknowlogick
merged 2 commits into
go-gitea:master
from
lunny:lunny/remove_attachment_missed_repo
Dec 14, 2019
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// Copyright 2019 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package migrations | ||
|
||
import ( | ||
"os" | ||
|
||
"code.gitea.io/gitea/models" | ||
"xorm.io/builder" | ||
"xorm.io/xorm" | ||
) | ||
|
||
func removeAttachmentMissedRepo(x *xorm.Engine) error { | ||
type Attachment struct { | ||
UUID string `xorm:"uuid"` | ||
} | ||
var start int | ||
attachments := make([]*Attachment, 0, 50) | ||
for { | ||
err := x.Select("uuid").Where(builder.NotIn("release_id", builder.Select("id").From("`release`"))). | ||
OrderBy("id").Limit(50, start).Find(&attachments) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
for i := 0; i < len(attachments); i++ { | ||
os.RemoveAll(models.AttachmentLocalPath(attachments[i].UUID)) | ||
} | ||
|
||
if len(attachments) < 50 { | ||
break | ||
} | ||
start += 50 | ||
attachments = attachments[:0] | ||
} | ||
|
||
_, err := x.Exec("DELETE FROM attachment WHERE release_id NOT IN (SELECT id FROM `release`)") | ||
return err | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to delete and commit inside the loop, after the
for{}
withos.RemoveAll
, just in case the operation is lengthy. In that caseOrderBy
and thestart
parameter will not be needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guillep2k That will spend more time than current implementation. And what's the advantage of that implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lunny It would just proceed in small batches, so if any problems come up during the procedure, at least the work that was done will be commited. On second thought, it not that important in this case.