Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog for 1.11.0-RC1 #9636

Merged
merged 19 commits into from
Jan 8, 2020
Merged

Changelog for 1.11.0-RC1 #9636

merged 19 commits into from
Jan 8, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 7, 2020

as title

6543
6543 commented Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 7, 2020
@lunny
Copy link
Member

lunny commented Jan 7, 2020

We should create a new release branch at first if all PRs merged. And then you can change the target branch to that one.

@techknowlogick techknowlogick changed the title Changelog for 1.11.0 Changelog for 1.11.0-RC1 Jan 7, 2020
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Jan 7, 2020
@techknowlogick techknowlogick added this to the 1.11.0 milestone Jan 7, 2020
techknowlogick
techknowlogick reviewed Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
techknowlogick
techknowlogick reviewed Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
techknowlogick
techknowlogick reviewed Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
techknowlogick
techknowlogick reviewed Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
techknowlogick
techknowlogick reviewed Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
techknowlogick
techknowlogick reviewed Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
techknowlogick
techknowlogick reviewed Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
techknowlogick
techknowlogick reviewed Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
techknowlogick
techknowlogick reviewed Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
guillep2k
guillep2k reviewed Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
jolheiser
jolheiser reviewed Jan 7, 2020
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some bugs that were a result of changes made in 1.11

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 8, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
guillep2k
guillep2k reviewed Jan 8, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
guillep2k
guillep2k approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

6543
6543 commented Jan 8, 2020
View reviewed changes
Copy link
Member Author

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 8, 2020
@6543
Copy link
Member Author

6543 commented Jan 8, 2020

LGTM

@6543
Copy link
Member Author

6543 commented Jan 8, 2020

@lunny can you approve the lgtm bot is joking :/

jolheiser
jolheiser approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 8, 2020
techknowlogick
techknowlogick reviewed Jan 8, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Jan 8, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
6543
6543 commented Jan 8, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@6543 @techknowlogick
Apply suggestions from code review
d1d3fb5 
Co-Authored-By: techknowlogick <matti@mdranta.net>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 8, 2020
@6543
Copy link
Member Author

6543 commented Jan 8, 2020

Lgtm bot is working .. weard

@6543
Copy link
Member Author

6543 commented Jan 8, 2020

@techknowlogick think it need your lgtm now 😅

@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 8, 2020
@6543
Copy link
Member Author

6543 commented Jan 8, 2020

Ready to merge 🚀?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 8, 2020
@lunny
Copy link
Member

lunny commented Jan 8, 2020

make L-G-T-M work

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 8, 2020
@lunny lunny merged commit bb44769 into go-gitea:master Jan 8, 2020
@6543 6543 deleted the changelog-1.11.0rc branch January 8, 2020 02:59
@sapk sapk removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 8, 2020
lafriks
lafriks reviewed Jan 8, 2020
View reviewed changes
CHANGELOG.md
* Support inline rendering of CUSTOM_URL_SCHEMES (#8496)
* Recalculate repository access only for specific user (#8481)
* Add download button for rull request diff- and patch-file (#8470)
* Add single sign-on support via SSPI on Windows (#8463)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is feature not enhancment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lafriks What's the diference? Are features 100% new while enhancements are an improvement over an existing feature?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the case, what about this (marked as enhancement)?:

* Use templates for issue e-mail subject and body (#8329)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D - we can make a list of "ned to change for final 1.11.0"

Copy link
Member

@lafriks lafriks Jan 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillep2k yes, feature that is something new that was implemented, enhancement are improved existing feature by adding something new to it or making it easier to use or more customizable etc

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@guillep2k guillep2k guillep2k approved these changes

@sapk sapk sapk left review comments

@lafriks lafriks lafriks left review comments

@techknowlogick techknowlogick techknowlogick left review comments

@tboerger tboerger tboerger left review comments

@lunny lunny lunny left review comments

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.