Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the AUTO_RANDOM Field #104

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Support the AUTO_RANDOM Field #104

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b09873
feat: support auto_random through default tag
Jan 29, 2023
120c47f
fix: unsigned type support
Jan 30, 2023
b3a1a34
fix: keeping the HasDefaultValue value is true for auto_random
Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ import (
"gorm.io/gorm/utils"
)

const (
AutoRandomTag = "auto_random()" // Treated as an auto_random field for tidb
)

type Config struct {
DriverName string
ServerVersion string
Expand Down Expand Up @@ -417,7 +421,32 @@ func (dialector Dialector) getSchemaBytesType(field *schema.Field) string {
return "longblob"
}

// autoRandomType
// field.DataType MUST be `schema.Int` or `schema.Uint`
// Judgement logic:
// 1. Is PrimaryKey;
// 2. Has default value;
// 3. Default value is "auto_random()";
// 4. IGNORE the field.Size, it MUST be bigint;
// 5. CLEAR the default tag, and return true;
// 6. Otherwise, return false.
func autoRandomType(field *schema.Field) (bool, string) {
if field.PrimaryKey && field.HasDefaultValue &&
strings.ToLower(strings.TrimSpace(field.DefaultValue)) == AutoRandomTag {
field.HasDefaultValue = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to set HasDefaultValue to false, it should be true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used this tag default:auto_random() to implement the auto_random feature. But it is actually not a default value. It's a field like auto_increment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for auto_increment fields we also marked them as HasDefaultValue, e.g:

https://github.com/go-gorm/gorm/blob/d834dd60b715422dc2a900fb2744f9c278a9830f/schema/field.go#L113

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it. I made a mistake.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. PTAL again.

field.DefaultValue = ""

return true, "bigint auto_random"
}

return false, ""
}

func (dialector Dialector) getSchemaIntAndUnitType(field *schema.Field) string {
if autoRandom, typeString := autoRandomType(field); autoRandom {
return typeString
}

constraint := func(sqlType string) string {
if field.DataType == schema.Uint {
sqlType += " unsigned"
Expand Down