Fix DataType Define #111
Fix DataType Define #111
Conversation
1. because select schema from db, return int2,int4,int8. but code name is smallint,integer,bigint. it will cause alter column. a. smallint -> int2 b. integer -> int4 c. bigint -> int8 2. in postgresql, set timestamptz Precision == 0, This means being accurate to the seconds.
| return fmt.Sprintf("timestamptz(%d)", field.Precision) | ||
| } | ||
| return "timestamptz" | ||
| // in postgresql, Precision == 0, This means being accurate to the seconds. |
There was a problem hiding this comment.
the default value of precision is 0, that why we ignored the zero value.
There was a problem hiding this comment.
the default value of precision is 0, that why we ignored the zero value.
if set default value， it will set type = "timestamptz", it same as "timestamptz(6)".
in current logic, no way to define type "timestamptz(0)"
There was a problem hiding this comment.
but this changed the default behavior and removed the default precision?
Maybe we need to check field's tag by using field.TagSettings["PRECISION"] if the precision's value is 0?
There was a problem hiding this comment.
The change here doesn't seem to make sense, because there was a problem here, It only works if the user doesn't set type.
field.DataType is set by user, when we using gorm:"type:"timestamptz", it's not equal schema.Time, and when we using gorm:"type:"time", it's means time of day (no date).
https://www.postgresql.org/docs/14/datatype-datetime.html
Edit
MyTime time.Time `gorm:"precision:6"`The reason why this triggers alter is because we mistakenly mistook precision for size
https://github.com/go-gorm/gorm/blob/master/migrator/migrator.go#L423
|
Get stuck with this issue. Looking forward to this can be merged and released soon. @a631807682 @jinzhu |
|
Fixed by commit #133 |
What did this pull request do?
User Case Description
a. smallint -> int2
b. integer -> int4
c. bigint -> int8