Solve testify dependency conflict #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olve the `gormigrate` library because of a conflict between namespaces. The `testify` library's documentation recommends consuming it with the github namespace and chances are that the majority of the consumers do that, rather than through gopk.in To fix the above I've changed the project's testify dependency to use the github namespace. After updating, but before building, probably want to run: ``` go mod tidy ``` As the caches may be "poisoned" with the wrong namespace. This fix will likely break compatibility with consumers using gopk.in and will require them to use testify's original namespace as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, any consumer using testify via github will fail to resolve the
gormigratelibrary because of a conflict between namespaces.The
testifylibrary's documentation recommends consuming it with the github namespace and chances are that the majority of the consumers do that, rather than through gopk.inTo fix the above I've changed the project's testify dependency to use the github namespace.
After updating, but before building, probably want to run:
As the caches may be "poisoned" with the wrong namespace.
This fix will likely break compatibility with consumers using gopk.in and will require them to use testify's original namespace as well