Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix holtWinters* functions handling of the bootstrapInterval parameter #775

Closed
carrieedwards opened this issue Jul 6, 2023 · 0 comments · Fixed by #776
Closed

Fix holtWinters* functions handling of the bootstrapInterval parameter #775

carrieedwards opened this issue Jul 6, 2023 · 0 comments · Fixed by #776
Labels

Comments

@carrieedwards
Copy link
Collaborator

The bootstrapInterval parameter in the holtWinters* functions is not being handled correctly. An issue is occurring when a bootstrapInterval that is not the default value of 7d is specified. In parser.go, the start time for holtWinters* functions is adjusted by subtracting 7 * 86400 (equivalent to 7 days), prior to the data being fetched. This is not taking the bootstrapInterval from the query into account, and is just applying the default value. However, if the bootstrapInterval is set to a different value, then inside of the holtWinters* functions, the from time is adjusted to the specified bootstrap interval, but the new starting time does not match the data that was previously fetched. This caused nil results to be returned. Instead, the specified bootstrapInterval (when included in the query) should be factoring in when adjusting the from time prior to fetching data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant