Use specified bootstrapInterval to adjust start time in holtWinters* functions #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…functions (#154) * Take specificed bootstrapInterval into consideration when adjusting holtWinters start times * Adjust holtWintersConfidenceArea from * Add tests for Metrics() function adjusting holtWinters from time
npazosmendez
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that was found with the holtWinters* functions. Previously, the code was adjusting the start time of these functions by 7 days, which is the default value for the bootstrapInterval parameter. However, if a different bootstrapInterval was specified, when the series was retrieved via GetSeriesArg, the from value in the request was altered by subtracting the bootstrapInterval, and the previously fetched data was not matching the request due to the altered start time. Thus, nil results were being returned. This PR fixes this by factoring in the specified bootstrapInterval when adjusting the start time for holtWinters* Functions, and only using the default of 7d if no bootstrapInterval is specified in the query.
See the Graphite-web implementation for more details (using holtWintersConfidenceBands as an example)