-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tagger: add two feature-flags that change seriesByTag behavior #266
Merged
msaf1980
merged 20 commits into
go-graphite:master
from
mchrome:fix/seriesByTag-inconsistency-with-carbon
Apr 24, 2024
Merged
tagger: add two feature-flags that change seriesByTag behavior #266
msaf1980
merged 20 commits into
go-graphite:master
from
mchrome:fix/seriesByTag-inconsistency-with-carbon
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchrome
commented
Mar 6, 2024
msaf1980
reviewed
Mar 11, 2024
msaf1980
reviewed
Mar 11, 2024
msaf1980
reviewed
Mar 11, 2024
mchrome
changed the title
tagger: fix several cases where gch behavior is different from carbon
tagger: add two feature-flags that change seriesByTag behavior
Mar 13, 2024
msaf1980
reviewed
Mar 21, 2024
almostinf
reviewed
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix two unintended (i believe) behaviors and adds two feature flags which affect what metrics are returned after filtering with seriesByTag.
Changes that work without feature flags
seriesByTag("name=test","env!=~stage|env")
now returns both metrics.request_success_total.counter;app=test;project=Test;environment=TEST;t=q request_success_total.counter;app=test;project=Test;environment=TEST;t=qac
Target
seriesByTag('t!=~qac')
didn't return anything.Now it returns
request_success_total.counter;app=test;project=Test;environment=TEST;t=q
This only happened when a term with
!=~
was the first tag after sorting terms by cost.Changes with feature flags
use-carbon-behaviour=true
.=
op and empty value (e.g.t=
) match all metrics that don't have that tag.dont-match-missing-tags=true
.!=
and!=~
operators only match metrics that have that tag.For example, without
dont-match-missing-tags=true
seriesByTag('t!=abc')
would matchmetric.name;tag=val
.