Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making DefaultSection modifyable to handle aws profile default. #293

Closed
wants to merge 1 commit into from
Closed

Making DefaultSection modifyable to handle aws profile default. #293

wants to merge 1 commit into from

Conversation

jade-clarke
Copy link
Contributor

This was done to fix the handling of aws credential files. If the default section is not modifyable then when the profiles are loaded from the credentials file, an erronious non-existent DEFAULT section is returned as part of the results array. When given the ability to modify DefaultSection and set it to lower case 'default', it loads the credentials as would be expected.

@jade-clarke
Copy link
Contributor Author

This was done to fix this issue: #287

@unknwon unknwon deleted the branch go-ini:master September 4, 2021 05:47
@unknwon unknwon closed this Sep 4, 2021
@unknwon
Copy link
Member

unknwon commented Sep 4, 2021

Hey! This PR was accidentally closed because master branch is no longer exists, would you mind re-open one against the new main branch? Thank you!

@jade-clarke
Copy link
Contributor Author

@unknwon I have reopened this in #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants