This repository has been archived by the owner on May 11, 2020. It is now read-only.
calculate number of imported funcs #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbinet
reviewed
Apr 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
+ Coverage 69.03% 69.05% +0.02%
==========================================
Files 51 51
Lines 5910 5914 +4
==========================================
+ Hits 4080 4084 +4
Misses 1467 1467
Partials 363 363
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I read the bug in #190
The problem is that when providing a nil imported object, the len(FunctionIndexSpace) is not equal to the number of imported funcs.
So I calculate it. I don't know if we can do it this way.
Thanks.