Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLDAP (RFC1798 UDP/Connectionless) support to DialURL #397

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

dsnt02518
Copy link
Contributor

This is actually a deprecated RFC, however Active Directory relies on it for server discovery.
Without this patch CLDAP is possible via directt use of the the deprecated Dial function with a UDP network connection. This patch adds the same support to the DialURL function via the 'cldap' URI scheme.

See https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-adts/8ebcf782-87fd-4dc3-8585-1301569dfe4f
and https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-adts/895a7744-aff3-4f64-bcfa-f8c05915d2e9 for MS documentation on this.

This is actually a deprecated RFC, however Active Directory relies on it
for server discovery.
Without this patch CLDAP is possible via directt use of the the
deprecated `Dial` function with a UDP network connection. This patch
adds the same support to the DialURL function.
@cpuschma cpuschma self-assigned this Oct 14, 2022
@cpuschma
Copy link
Member

Thank you for your PR! I'll look into this next week or maybe this weekend 😊

Copy link
Member

@cpuschma cpuschma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared your changes to the RFC and tested this against a domain controller (functional level 2016). LGTM!

I'll leave the PR open for a few days for others to comment. Once again, thank you for your PR 👍

@cpuschma cpuschma merged commit 93825e9 into go-ldap:master Oct 15, 2022
inv2004 pushed a commit to inv2004/ldap that referenced this pull request Jan 17, 2023
* Add CLDAP (RFC1798 UDP/Connectionless) support to DialURL

This is actually a deprecated RFC, however Active Directory relies on it
for server discovery.
Without this patch CLDAP is possible via directt use of the the
deprecated `Dial` function with a UDP network connection. This patch
adds the same support to the DialURL function.

* Mirror code changes to root folder

Co-authored-by: Christopher Puschmann <cp@lumen.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants