Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method now may receive strings with GTID sets #569

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

mialinx
Copy link
Contributor

@mialinx mialinx commented Apr 13, 2021

No description provided.

@lance6716
Copy link
Collaborator

lance6716 commented Apr 16, 2021

Hi, I think your PR will enable supporting multiple GTID updating, but will it happen in practice? Every binlog event should contains only one GTID

@mialinx
Copy link
Contributor Author

mialinx commented Apr 16, 2021

Every binlog event should contains only one GTID

Hi!

Sure, but GTIDSet types may be used for general GTID calculations.
For instance, we may calculate full GTID stored on the replica as Retrieved_Gtid_Set + Executed_Gtid_Set
Both may contain multiple GTIDs from different sources.

P.S. Actually, I'm going to open source for mysql HA tool we use in cloud.yandex.ru. It uses patched go-mysql for GTID handling. So I thought it would be right to publish this patch and use upstream version of go-mysql.

@lance6716 lance6716 merged commit 911015d into go-mysql-org:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants