Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced all %lu, %ld and %u to %d for correct formatting of errors #594

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

skoef
Copy link
Contributor

@skoef skoef commented Jun 25, 2021

Many error messages were probably taken verbatim from MySQL's source without converting the format specifiers from C to Go. In Go, fmt treats all integers as int64 internally and makes no difference in signed, unsigned or long integers.

Currently:
ERROR 1094 (HY000): Unknown thread id: %!l(uint32=234423432)u

With this PR:
ERROR 1094 (HY000): Unknown thread id: 234423432

@skoef
Copy link
Contributor Author

skoef commented Jun 25, 2021

@atercattus this might be a no-brainer

@lance6716 lance6716 merged commit fee2114 into go-mysql-org:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants