Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds parsing of IntVarEvents #624

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Adds parsing of IntVarEvents #624

merged 1 commit into from
Sep 16, 2021

Conversation

IvoGoman
Copy link
Contributor

Added support for parsing the IntVarEvents as I have the need to parse these events.

  • Removes the comment about IntVarEvents not being parsed
  • Adds IntVarEvent and enables parsing of the event
  • Adds rudimentary test

atercattus
atercattus approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@atercattus atercattus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with https://dev.mysql.com/doc/internals/en/intvar-event.html

@lance6716 lance6716 merged commit 1629d9b into go-mysql-org:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atercattus atercattus atercattus approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvoGoman @atercattus @lance6716