packet: memory optimization for reading network packet #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zr-hebo
changed the title
atercattus
reviewed
Dec 10, 2021
zr-hebo
force-pushed
the
master
branch
2 times, most recently
from
38536a6
to
f136121
Compare
atercattus
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
读取网络包遇到大的 event之后，会导致 buffer冲的很大，之后一直没法释放。从而导致整个程序的内存占用居高不下。
What is changed and how it works?
这个PR对这块逻辑做了优化，只缓存比较小的缓存块，避免了这种情况。
--
The buffer will be increased and can't be released when the packet is very big, thus the memory consumption keeps high.
This PR tries to avoid it.