Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix that forget to readOK after writing #652

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Dec 13, 2021

close #535

trigger condition: https://github.com/pingcap/ticdc/issues/3847#issuecomment-992225272

tested on my local MySQL 8.0.17

Copy link
Member

@atercattus atercattus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like forgotten

_, err = c.readOK()
return err

from neighbour branch AUTH_SHA256_PASSWORD

So, lgtm.

@lance6716 lance6716 merged commit 1efc79e into go-mysql-org:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canal error: "invalid sequence 6 != 1" on first authentication
2 participants