Add MysqlGTIDSet.Add() and Minus() methods #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostinru
commented
Jan 18, 2022
ostinru
commented
- fix off-by-one error
lance6716
reviewed
Jan 19, 2022
| @@ -180,6 +180,8 @@ func (t *mysqlTestSuite) TestMysqlGTIDMinus(c *check.C) { | |||
| {"3E11FA47-71CA-11E1-9E33-C80AA9429562:20-57:60-90", "3E11FA47-71CA-11E1-9E33-C80AA9429562:23", "3E11FA47-71CA-11E1-9E33-C80AA9429562:20-22:24-57:60-90"}, | |||
| {"3E11FA47-71CA-11E1-9E33-C80AA9429562:20-57:60-90", "3E11FA47-71CA-11E1-9E33-C80AA9429562:22-70", "3E11FA47-71CA-11E1-9E33-C80AA9429562:20-21:71-90"}, | |||
| {"3E11FA47-71CA-11E1-9E33-C80AA9429562:28-57", "3E11FA47-71CA-11E1-9E33-C80AA9429562:28-57", ""}, | |||
There was a problem hiding this comment.
found a failed case
{"3E11FA47-71CA-11E1-9E33-C80AA9429562:20-21", "3E11FA47-71CA-11E1-9E33-C80AA9429562:21", "3E11FA47-71CA-11E1-9E33-C80AA9429562:20"},
please check it
There was a problem hiding this comment.
You right.
New version with changes:
- merge 2 loops into one, so it will be easier to reason about
- explicit IF conditions to make it clear which cases are handled in each branch
Hope, this time it is correct for all inputs
* fix off-by-one error
lance6716
approved these changes
Jan 20, 2022
| if j < len(in) { | ||
| subtrahend = in[j] | ||
| } else { | ||
| subtrahend = Interval{math.MaxInt64, math.MaxInt64} |
There was a problem hiding this comment.
I think we can
append minuend to n
check if i+1 out of range and append s.Intervals[i+1:]... to n
it's OK not to change
There was a problem hiding this comment.
There were 2 bugs in 50 lines :(
So, I would prefer not to increase cyclomatic complexity of this code and keep it as it in PR.
There was a problem hiding this comment.
wait @atercattus 's review as this function is complex
There was a problem hiding this comment.
Hi, @atercattus have you had a chance to look into this?
There was a problem hiding this comment.
(I'm going to merge this PR if he does not respond it tomorrow)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.