Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pingcap/tidb parser to new location #834

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Oct 27, 2023

The tidb parser moved in pingcap/tidb#47123

This updates the dependency to the new location.

@lance6716
Copy link
Collaborator

Error: ../../../go/pkg/mod/github.com/pingcap/tidb/pkg/parser@v0.0.0-20231027131104-30288c77c7e8/charset/charset.go:17:2: package cmp is not in GOROOT (/opt/hostedtoolcache/go/1.20.10/x64/src/cmp)

Oh TiDB's parser seems have used go 1.21 standard libraries, but this library doesn't. And I'm a bit worried more users of this library have not preprared to upgrade to go 1.21. @morgo Do you need the latest parser or we can choose a go 1.20 commit ?

@morgo
Copy link
Contributor Author

morgo commented Oct 29, 2023

Oh TiDB's parser seems have used go 1.21 standard libraries, but this library doesn't. And I'm a bit worried more users of this library have not preprared to upgrade to go 1.21. @morgo Do you need the latest parser or we can choose a go 1.20 commit ?

Sorry, I didn't test early than go 1.21. I don't need the latest, and can chose a go 1.20 commit.

My motivation was just to bump it because tidb only recently started officially advertising 8.0 compatibility. I know the parser was more or less there for a while, but there have been some syntax changes even within 8.0's release, so I wanted to make sure it was based on something closer to master.

morgo and others added 2 commits October 30, 2023 09:31
Signed-off-by: lance6716 <lance6716@gmail.com>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@lance6716 lance6716 merged commit 9e77fe8 into go-mysql-org:master Nov 1, 2023
13 checks passed
@morgo morgo deleted the update-dependencies branch November 1, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants