Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass bearer token #124

Merged
merged 7 commits into from
Feb 6, 2023
Merged

Pass bearer token #124

merged 7 commits into from
Feb 6, 2023

Conversation

boryashkin
Copy link
Contributor

@boryashkin boryashkin commented Jul 24, 2022 •
edited
Loading

#123

An example for the issue

@boryashkin boryashkin requested a review from umputun as a code owner July 24, 2022 22:06
@boryashkin boryashkin marked this pull request as draft August 7, 2022 10:23
@boryashkin boryashkin force-pushed the pass-bearer-token branch 3 times, most recently from 6db3738 to 308c7b1 Compare January 9, 2023 20:57
@boryashkin boryashkin marked this pull request as ready for review January 9, 2023 21:47
@boryashkin
Copy link
Contributor Author

I found no way to add a hook to constructors of existing providers, so it will be only possible with the CustomProvider (user of the lib could easily copy/paste params of preexisting providers and construct it via AddCustomProvider or NewCustom)

@coveralls
Copy link

coveralls commented Jan 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4008456731

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 95.736%
Files with Coverage Reduction New Missed Lines %
auth.go 4 95.74%
Totals Coverage Status
Change from base Build 3832831444: 0.05%
Covered Lines: 247
Relevant Lines: 258
💛 - Coveralls

umputun
umputun requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of minor thing

provider/oauth2.go Outdated Show resolved Hide resolved
provider/oauth2.go Outdated Show resolved Hide resolved
umputun
umputun approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@umputun umputun merged commit 428a4a6 into go-pkgz:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boryashkin @coveralls @umputun