Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS InsecureSkipVerify option #187

Merged
merged 3 commits into from
Dec 11, 2023
Merged

TLS InsecureSkipVerify option #187

merged 3 commits into from
Dec 11, 2023

Conversation

vladimirdulov
Copy link

@vladimirdulov vladimirdulov commented Dec 1, 2023

@umputun @paskal Please review if you are OK with go.mod changes. perhaps a new release of email lib is required.

Also could you advise how to update email and auth libs properly in remark42 app, is it just a copy over?

provider/sender/email_test.go Outdated Show resolved Hide resolved
provider/sender/email.go Outdated Show resolved Hide resolved
@vladimirdulov
Copy link
Author

The code has been updated in accordance to @paskal comments.

@vladimirdulov
Copy link
Author

@paskal just submitted go.sum, can we try to run CI again?

@vladimirdulov
Copy link
Author

Could you merge it so I can continue TLS InsecureSkipVerify option implementaton in remark42 app?

Also please advise how to properly get auth and emails libs updated in the remark42 repo.

@umputun umputun merged commit 0fc8abc into go-pkgz:master Dec 11, 2023
5 checks passed
@umputun
Copy link
Member

umputun commented Dec 11, 2023

LGTM, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants