Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename github.com/nullrocks/identicon to github.com/rrivera/identicon #192

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

avbasov
Copy link
Contributor

@avbasov avbasov commented Jan 16, 2024

Seems like the author decided to change the username. No changes to the logic of the library.
rrivera/identicon@2e77a2e

@avbasov
Copy link
Contributor Author

avbasov commented Jan 16, 2024

Oh, I overlooked that the library now requires go 1.21.5. I asked the author if we could change the requirements. rrivera/identicon#4

@avbasov
Copy link
Contributor Author

avbasov commented Jan 16, 2024

Well. With go 1.20 in CI it won't pass anyway. May I change the build workflow?

@umputun
Copy link
Member

umputun commented Jan 16, 2024

Feel free to bump the compiler to 1.21 and adjust the workflow accordingly

@avbasov
Copy link
Contributor Author

avbasov commented Jan 17, 2024

Sorry for the mess.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7552074817

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.746%

Totals Coverage Status
Change from base Build 7481844759: 0.0%
Covered Lines: 2561
Relevant Lines: 3095

💛 - Coveralls

@umputun
Copy link
Member

umputun commented Jan 17, 2024

thx

@umputun umputun merged commit f721b8c into go-pkgz:master Jan 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants