-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve provider name handling #213
Open
cyb3r4nt
wants to merge
8
commits into
go-pkgz:master
Choose a base branch
from
cyb3r4nt:fix-providers-names
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jun 3, 2024
-
Fix registration of dev provider in Service.authMiddleware.Providers
Now it is possible to have a configuration, where only one single dev provider is enabled. Providers were not registered into Service.authMiddleware.Provicers slice in the Service.AddDevProvider() and Service.AddAppleProvider() methods before.
Configuration menu - View commit details
-
Copy full SHA for 30656d6 - Browse repository at this point
Copy the full SHA 30656d6View commit details
Commits on Jul 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ec4b929 - Browse repository at this point
Copy the full SHA ec4b929View commit details
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ec38494 - Browse repository at this point
Copy the full SHA ec38494View commit details
Commits on Aug 29, 2024
-
improve provider name handling
Add provider name into JWT token claims to allow provider names with multiple underscore "_" symbols. Forbid provider names containing URL reserved symbols.
Configuration menu - View commit details
-
Copy full SHA for f13649e - Browse repository at this point
Copy the full SHA f13649eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fe2f59 - Browse repository at this point
Copy the full SHA 8fe2f59View commit details
Commits on Sep 2, 2024
-
fix race conditions in TestTelegramConfirmedRequest
There were two different race conditions between logic in TestTelegramConfirmedRequest and TelegramAPIMock.GetUpdatesFunc and TelegramAPIMock.SendFunc: * GetUpdatesFunc may start before token was fetched, then it produces empty telegramUpdate response, which causes assertions in SendFunc to fail. * When token becomes used and removed from wait queue after successful login completion, then GetUpdatesFunc may be still called and new telegram update is created for same token. This breaks telegram update processing logic, and SendFunc gets called with the error parameter, which also breaks assertions.
Configuration menu - View commit details
-
Copy full SHA for 178b002 - Browse repository at this point
Copy the full SHA 178b002View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c9db77 - Browse repository at this point
Copy the full SHA 0c9db77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a80324 - Browse repository at this point
Copy the full SHA 5a80324View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.