Validate nested structs (take 2) #668
Open
+145
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deankarn
requested changes
Jan 9, 2021
| v.fldIsPointer = vFldIsPointerOld | ||
| ns = oldNs | ||
| structNs = oldStructNs | ||
| if len(v.errs) > previousErrorsCount { |
There was a problem hiding this comment.
Unfortunately I think this suffers from the same issue as another take on validating structs using tags.
The validations for the structs need to be run first and then the fields of that struct IF no errors occurred on the struct validations. this is important to be able to use validations like required with structs.
Achieving this however requires reworking of how the caching works in the library. It is achievable but needs much larger changes to occur.
There was a problem hiding this comment.
This has been already discussed, see #591 (comment)
|
Should we close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367 .
Make sure that you've checked the boxes below before you submit PR:
Change Details:
This change allows using (any: custom or backed in) validations on nested structs. This is the corrected version of #591.
@go-playground/admins