Parallelize test

[shogo82148]

Description

To reduce testing time, we will parallelize the tests.

Checklist

• Code compiles correctly
• Created tests which fail without the change (if possible)
• All tests passing
• Extended the README / documentation, if necessary
• Added myself / the copyright holder to the AUTHORS file

Summary by CodeRabbit

• Refactor

  • Enhanced the test suite to run tests in parallel, improving execution speed and efficiency.

• Tests

  • Updated test functions to support parallel execution, ensuring robustness and reliability of the testing process.

[coderabbitai]

Walkthrough

The project's test suite has been updated to run tests in parallel, improving efficiency and reducing execution time. A new function for parallel test execution has been introduced, and existing test functions have been adapted to support this change. The go test command now includes a flag to specify the level of concurrency, which is set to 10.

Changes

File(s)	Change Summary
.github/workflows/test.yml	Added -parallel 10 flag to go test command to enable parallel test execution with 10 goroutines.
.../conncheck_test.go	Modified TestStaleConnectionChecks to use runTestsParallel with an additional parameter.
.../driver_test.go	Added runTestsParallel function, updated runTests, and refactored test functions for parallelism.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment made by CodeRabbit.
• You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
• You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coveralls]

coverage: 82.121% (-0.5%) from 82.627%
when pulling 5965ccb on shogo82148:parallelize-test
into fc589cb on go-sql-driver:master.

[coderabbitai]

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between fc589cb and 5965ccb.

Files selected for processing (3)

• .github/workflows/test.yml (1 hunks)
• conncheck_test.go (1 hunks)
• driver_test.go (59 hunks)

Additional comments: 5

.github/workflows/test.yml (4)

• 99-99: The addition of the -parallel 10 flag to the go test command is correct and aligns with the PR's objective to parallelize test execution. Ensure that the tests are designed to be run in parallel without shared state that could lead to race conditions or flaky tests.

• 96-102: Before merging, verify that the code compiles correctly and that all tests pass with the new parallel test configuration.

• 96-102: Check if the README or other documentation needs to be updated to reflect the changes in test execution, such as the addition of the -parallel flag and any new requirements for writing tests.

• 96-102: Ensure that the author's information is added to the AUTHORS file if that is part of the project's contribution guidelines.

conncheck_test.go (1)

• 19-23: The change from runTests to runTestsParallel aligns with the PR's objective to parallelize tests. Ensure that the runTestsParallel function is implemented correctly and that the additional parameter _ string is handled properly. Also, confirm that the code compiles, all tests are passing, and update the README/documentation and AUTHORS file if necessary.

[coderabbitai]

The test TestValuerWithValueReceiverGivenNilValue is missing an assertion to verify the expected behavior. It should check whether the INSERT operation with a nil value is handled correctly by the driver.

// After the INSERT operation, there should be an assertion here to check the expected outcome.
// For example, if the expected behavior is that the INSERT should succeed and store a NULL value in the database,
// then the test should query the database to verify that the value is indeed NULL.

---

The test TestValuerWithValueReceiverGivenNilValue should include cleanup logic to remove the test data after the test is run to ensure it does not affect other tests.

// After the test logic, there should be a cleanup step to remove the inserted row or drop the test table.
// This can be done using a defer statement right after the table creation or at the end of the test.