Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read / write timeouts #401

Merged
merged 4 commits into from
Jan 19, 2016
Merged

read / write timeouts #401

merged 4 commits into from
Jan 19, 2016

Conversation

julienschmidt
Copy link
Member

supersedes #372 with the following improvements:

  • use local attributes for timeouts
  • do not type assert to net.Conn each time
  • DSN params are CamelCase

Fixes #257
Fixes #375

@julienschmidt julienschmidt added this to the v1.3 milestone Jan 12, 2016
@julienschmidt julienschmidt mentioned this pull request Jan 12, 2016
Closed
3 tasks
@julienschmidt
Copy link
Member Author

@arnehormann ping
(also #403)

@arnehormann
Copy link
Member

s/string of decimal numbers, each with optional fraction and a unit suffix/decimal number with a unit suffix/g (in readTimeout, writeTimeout, timeout)
LGTM

chakrit and others added 3 commits January 19, 2016 15:48
@chakrit @julienschmidt
read_timeout and write_timeout
de0bbfa
@julienschmidt
Improve timeouts implementation
68ca989 
- use local attributes for timeouts
- do not type assert to net.Conn each time
- DSN params are CamelCase
@julienschmidt
Update README.md
2cd96dd 
Add readTimeout and writeTimeout params
@julienschmidt
Copy link
Member Author

PTAL
rebased and fixed the README (also "a unit suffix" -> "an unit suffix")

@arnehormann
Copy link
Member

LGTM

julienschmidt added a commit that referenced this pull request Jan 19, 2016
@julienschmidt
Merge pull request #401 from go-sql-driver/timeout
72ea5d0 
read / write timeouts
@julienschmidt julienschmidt merged commit 72ea5d0 into master Jan 19, 2016
@julienschmidt julienschmidt deleted the timeout branch January 19, 2016 15:21
@daniellee daniellee mentioned this pull request Feb 9, 2016
Closed
@ElPeque ElPeque mentioned this pull request Oct 31, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@julienschmidt @arnehormann @chakrit