Merge pull request github#2 from go1com/DO-2240

Correct usage of secrets
go1com · Apr 11, 2024 · f94ad3c · f94ad3c
2 parents c8e1d0f + ecfdbbf
commit f94ad3c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/.github/workflows/go1-helm-deploy.yml b/.github/workflows/go1-helm-deploy.yml
@@ -10,11 +10,11 @@ on:
         description: 'Release tag from the previous workflow'
         required: true
 env:
-  KUBECONFIG_CONTENTS: secrets.KUBECONFIG_PRODUCTION_K8S_AU
+  KUBECONFIG_CONTENTS: ${{ secrets.KUBECONFIG_PRODUCTION_K8S_AU }}
   # require envs for safe-settings app https://github.com/github/safe-settings/blob/main-enterprise/docs/deploy.md
-  APP_ID: secrets.APP_ID
-  WEBHOOK_SECRET: secrets.WEBHOOK_SECRET
-  PRIVATE_KEY: secrets.PRIVATE_KEY
+  APP_ID: ${{ secrets.APP_ID }}
+  WEBHOOK_SECRET: ${{ secrets.WEBHOOK_SECRET }}
+  PRIVATE_KEY: ${{ secrets.PRIVATE_KEY }}
 jobs:
   deploy-to-aks:
     if: ${{ github.event.inputs.status == 'passed' }}

diff --git a/go1-values-override.yaml b/go1-values-override.yaml
@@ -1,5 +1,4 @@
-deploymentConfig:
-  {}
+deploymentConfig: {}
 
 ingress:
   enabled: true