Skip to content
This repository has been archived by the owner on Aug 17, 2020. It is now read-only.

wrong count of executed requests #113

Closed
zeph opened this issue Apr 24, 2017 · 7 comments
Closed

wrong count of executed requests #113

zeph opened this issue Apr 24, 2017 · 7 comments
Assignees
Labels

Comments

@zeph
Copy link
Member

zeph commented Apr 24, 2017

@cwaltken-edrans shouldn't be 1000 the default?

$ ../goad_copy/build/osx/x86-64/goad -u http://www.olx.com
Regional results

Region: us-east-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       333     1.0 MB     0.007s     426.99    1257.58
   Slowest    Fastest   Timeouts  TotErrors
    0.156s     0.003s          0          0

Overall

   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       333     1.0 MB     0.007s     426.99    1257.58
   Slowest    Fastest   Timeouts  TotErrors
    0.156s     0.003s          0          0
HTTPStatus   Requests
       200        333

$ ../goad_copy/build/osx/x86-64/goad -u http://www.olx.com -c 999
Regional results

Region: us-east-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
        10      30 kB     0.013s     513.74    1512.62
   Slowest    Fastest   Timeouts  TotErrors
    0.026s     0.006s          0          0

Overall

   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
        10      30 kB     0.013s     513.74    1512.62
   Slowest    Fastest   Timeouts  TotErrors
    0.026s     0.006s          0          0
HTTPStatus   Requests
       200         10

$ ../goad_copy/build/osx/x86-64/goad -u http://www.olx.com -n 999
Regional results

Region: us-east-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       333     991 kB     0.010s     309.98     900.57
   Slowest    Fastest   Timeouts  TotErrors
    0.082s     0.004s          0          0

Overall

   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       333     991 kB     0.010s     309.98     900.57
   Slowest    Fastest   Timeouts  TotErrors
    0.082s     0.004s          0          0
HTTPStatus   Requests
       200        333


@zeph
Copy link
Member Author

zeph commented Apr 24, 2017

this is a build after merging #112 into master

@cwaltken-edrans
Copy link
Collaborator

Yes that's right. I can not reproduce the error though. Are you sure your lambda functions on the specified regions are up to date? I did not bump the version on that commit.

I've got the following output for the commands you ran:

$ goad -u https://example.com
Regional results

Region: ap-northeast-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       334     202 kB     0.121s      25.64      15.17
   Slowest    Fastest   Timeouts  TotErrors
    0.485s     0.112s          0          0
Region: us-east-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       333     202 kB     0.002s    1431.07  867231.25
   Slowest    Fastest   Timeouts  TotErrors
    0.044s     0.001s          0          0
Region: eu-west-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       333     202 kB     0.095s      32.54      19.26
   Slowest    Fastest   Timeouts  TotErrors
    0.395s     0.088s          0          0

Overall

   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
      1000     606 kB     0.073s    1489.26  867265.69
   Slowest    Fastest   Timeouts  TotErrors
    0.485s     0.001s          0          0
HTTPStatus   Requests
       200       1000

$ goad -u https://example.com -c 999
Regional results

Region: us-east-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       340     206 kB     0.060s     159.81   96843.85
   Slowest    Fastest   Timeouts  TotErrors
    0.150s     0.002s          0          0
Region: eu-west-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       330     200 kB     0.384s      24.30      14.38
   Slowest    Fastest   Timeouts  TotErrors
    0.526s     0.085s          0          0
Region: ap-northeast-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       330     200 kB     0.451s      20.87      12.35
   Slowest    Fastest   Timeouts  TotErrors
    0.592s     0.107s          0          0

Overall

   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
      1000     606 kB     0.296s     204.99   96870.59
   Slowest    Fastest   Timeouts  TotErrors
    0.592s     0.002s          0          0
HTTPStatus   Requests
       200       1000

$ goad -u https://example.com -n 999
Regional results

Region: eu-west-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       333     202 kB     0.094s      32.93      19.49
   Slowest    Fastest   Timeouts  TotErrors
    0.381s     0.088s          0          0
Region: ap-northeast-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       333     202 kB     0.126s      24.68      14.61
   Slowest    Fastest   Timeouts  TotErrors
    0.486s     0.114s          0          0
Region: us-east-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       333     202 kB     0.002s    1546.91  937426.38
   Slowest    Fastest   Timeouts  TotErrors
    0.043s     0.001s          0          0

Overall

   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       999     605 kB     0.074s    1604.52  937460.50
   Slowest    Fastest   Timeouts  TotErrors
    0.486s     0.001s          0          0
HTTPStatus   Requests
       200        999

@cwaltken-edrans
Copy link
Collaborator

The error you see was introduced in the version before and should no longer appear in the merged version you are testing. Could you please make sure you are running the latest version of the code?

@zeph
Copy link
Member Author

zeph commented Apr 25, 2017

@cwaltken-edrans i guess with a high level of certainty that this is related to this #91

can we address it properly? like comparing an md5 of the lambda function which is on the amazon infrastructure?

cwaltken-edrans referenced this issue Apr 25, 2017
 * add missing region in SQS data
 * allow execution by time rather than quantity of requirements
 * add test for stresstestTimeout
 * fix remainingRequestCount negative termination check
 * add test execution to Makefile
 * update golang versions to 1.8 in Dockerfile and Godeps
@cwaltken-edrans
Copy link
Collaborator

Yes, we will address this properly.

I've started working on creating a pull request for homebrew. To create a nice and simple recipe for hombrew I will touch the build process in the Makefile to allow for a platform specific make install.

At the same time i will mark the builds with an additional build flag. I'll use the last commit hash of the git repository to identify the build of the cli and the lambda function. Also i will set the timestamps in the generated zipfiles to the time of the last commit to ensure reproducible builds with identical shasums if we don't have any code changes.

@zeph
Copy link
Member Author

zeph commented Apr 25, 2017

@cwaltken-edrans I was thinking of a binary Cask receipt, but ok
... depends how much effort u need to put into this

@zeph
Copy link
Member Author

zeph commented Apr 25, 2017

yeah, my fault, wrong build

$ ../goad_copy/build/osx/x86-64/goad -u http://www.olx.com
Regional results

Region: us-east-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       333     1.0 MB     0.007s     399.65 1213459.50
   Slowest    Fastest   Timeouts  TotErrors
    0.638s     0.003s          0          0
Region: eu-west-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       333     1.0 MB     0.010s     301.87  918484.44
   Slowest    Fastest   Timeouts  TotErrors
    0.573s     0.003s          0          0
Region: ap-northeast-1
   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
       334     1.0 MB     0.006s     469.17    1379.12
   Slowest    Fastest   Timeouts  TotErrors
    0.234s     0.003s          0          0

Overall

   TotReqs   TotBytes    AvgTime   AvgReq/s  AvgKbps/s
      1000     3.0 MB     0.008s    1170.69 2133323.00
   Slowest    Fastest   Timeouts  TotErrors
    0.638s     0.003s          0          0
HTTPStatus   Requests
       200       1000

@zeph zeph closed this as completed Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants