This repository has been archived by the owner on Aug 17, 2020. It is now read-only.
break 5min lambda barrier #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add tests for fetch function * extract methods to prepare and send requests * move timestamping closer to request execution * create a struct holding the state of lambda execution * simplify method calls * break down runLoadTest method to simplify cascading for loops * simplify spawn logic for request worker go routines * extract lambdaSettings as struct * move code for the lambdas initial state into setup methods * setup some default values for lambda * create various tests for runLoadTest * extract method to parse lambda settings * simplify requestParameters * extract calculation of intermediary results to separate structs * introduce request metric struct to reduce complexity of result calculaton * add timeout tests * introduce interface for SQSAdapter to mock during testing * use elapsed to calculade lastRequestTime for more precise results * add tests for quitting on lambda timeout * assert last result is sent on timeout * apply rename refactoring to functions and variables * allow to fork into new AWS Lambda on AWS timeout
* fix test codesmells * fix TotBytes read with new aggregation function * use aws.lambda via interface to improve testing * fix request count transmitted to the cli * set the AWS_TIMEOUT back to almost 5 minutes
* add missing region in SQS data * allow execution by time rather than quantity of requirements * add test for stresstestTimeout * fix remainingRequestCount negative termination check * add test execution to Makefile * update golang versions to 1.8 in Dockerfile and Godeps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #102 the 5 minute execution timeout that is inherent to execution of lambda functions on aws.
The commit introduces a lot of changes to lambda/lambda.go mainly because the code execution paths became increasingly hard to follow. To make changes without introducing breaking changes to the API a small suite of unit tests was added to accompany the refactoring.
This commit also fixes a bug terminating the CLI to early when more then one lambda is running in a region.
Functional changes are:
This is the list of individual changes introduced by the refactoring: