Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-31232: Implement "group create" event for the EDA #4178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nkoporec
Copy link
Contributor

Problem (for internal)

Currently we don't have an EDA event that fires when a group is created.

Solution (for internal)

Add the new event

Payload:

{
	"specversion": "1.0",
	"id": "0a3cf2e0-46df-48b6-aba0-dd5ea1318ef3",
	"source": "/group/add/flexible_group",
	"type": "com.getopensocial.cms.group.create",
	"datacontenttype": "application/json",
	"time": "2024-11-11T08:15:09Z",
	"data": {
		"event": {
			"id": "a480105c-7883-486a-8963-2c1821cdf6fd",
			"created": "2024-11-11T08:15:09",
			"updated": "2024-11-11T08:15:09",
			"status": "published",
			"label": "Group 1",
			"visibility": {
				"type": "public",
				"roles": []
			},
			"contentVisibility": {
				"type": "public",
				"roles": []
			},
			"membership": {
				"method": "request"
			},
			"type": "flexible_group",
			"author": {
				"id": "53bb767a-cdc0-4872-81eb-9a4db10374bf",
				"displayName": "admin",
				"href": {
					"canonical": "https://opensocial.ddev.site/user/1/home"
				}
			},
			"address": {
				"label": "",
				"countryCode": "",
				"administrativeArea": "",
				"locality": "",
				"dependentLocality": "",
				"postalCode": "",
				"sortingCode": "",
				"addressLine1": "",
				"addressLine2": ""
			},
			"href": {
				"canonical": "https://opensocial.ddev.site/group/20/stream"
			}
		},
		"actor": {
			"application": null,
			"user": {
				"id": "53bb767a-cdc0-4872-81eb-9a4db10374bf",
				"displayName": "admin",
				"href": {
					"canonical": "https://opensocial.ddev.site/user/1/home"
				}
			}
		}
	}
}

Release notes (to customers)

Issue tracker

https://getopensocial.atlassian.net/browse/PROD-31232

Theme issue tracker

How to test

  1. Enable social_eda
  2. Enable and set up the social_eda_dispatcher
  3. Create a new group.
  4. An event should be dispatched with the payload similar to above

Change Record

Translations

@nkoporec nkoporec added team: enterprise This PR originates from the ECI team type: feature Adds a new feature to Open Social status: needs review This pull request is waiting for a requested review prio: medium labels Nov 11, 2024
@nkoporec nkoporec added this to the 13.0.0-alpha18 milestone Nov 11, 2024
@nkoporec nkoporec force-pushed the feat/enterprise/PROD-31232/implement-group-create-event-handler branch 2 times, most recently from 748b636 to 7dc9937 Compare November 11, 2024 16:10
@ribel ribel changed the title PROD-31232 - Implement "group create" event for the EDA PROD-31232: Implement "group create" event for the EDA Nov 13, 2024
@ribel ribel force-pushed the feat/enterprise/PROD-31232/implement-group-create-event-handler branch from 7dc9937 to 763e00d Compare November 13, 2024 11:24
@ribel
Copy link
Contributor

ribel commented Nov 13, 2024

@nkoporec I have rebased with main (which is fixed now), but I still see that PHPStan and PHPCS still failing.
Could you check it, please?

@nkoporec nkoporec force-pushed the feat/enterprise/PROD-31232/implement-group-create-event-handler branch 3 times, most recently from b6e51fa to 60be6fd Compare November 13, 2024 16:10
@nkoporec nkoporec force-pushed the feat/enterprise/PROD-31232/implement-group-create-event-handler branch from 60be6fd to 8ca8e8b Compare November 13, 2024 16:10
@open-social-tugboat
Copy link

Tugboat has finished building the preview for this pull request!

Link:

Dashboard:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: enterprise This PR originates from the ECI team type: feature Adds a new feature to Open Social
Development

Successfully merging this pull request may close these issues.

3 participants