Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3373075 by tbsiqueira: Update dev/test dependencies #70

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

tbsiqueira
Copy link
Contributor

@tbsiqueira tbsiqueira commented Jul 7, 2023

Please check the following pull request with the full explanation on why we need this changes:

goalgorilla/open_social#3457

🚨 After Merge 🔥

We should tag this repo as 1.4.0 and use it on goalgorilla/open_social#3457

🚀 🔥 Related PRs 🔥 🚀

This is a PR from a series of 5 PRs that should be merged in the following order:

  1. Issue #3373075 by tbsiqueira: Update dev/test dependencies #70
  2. Issue #3373172 by tbsiqueira: Update our tugboat docker image with one supporting PHP 8.1 open_social#3460
  3. Issue #3373075 by tbsiqueira: Update from drupal/core-recommended to drupal/core open_social#3457
  4. Update our Doocker setup to use PHP 8.1 images drupal_social#392 ( this is just a private repository that we use for development, this will not be available for public users )
  5. Issue #3368689 by tbsiqueira: Update behat tests to use the new compatible php 8.1 images open_social#3439

They are ALL BC and should not cause any breaking change for our local development

Since drupal/drupal-extension:v4.2.1 is not PHP 8.1 compatible due to a
guzzlehttp/guzzle dependency we need to add the ability to require either v4 or v5

We also need to downgrade PHPStan version since it's showing more checks than needed
Copy link

@zanvidmar zanvidmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Note: phpstan was deliberately downgraded.

@tbsiqueira tbsiqueira changed the title Issue #3373075 by tbsiqueira: Update from drupal/core-recommended to drupal/core Issue #3373075 by tbsiqueira: Update dev/test dependencies Jul 10, 2023
@tbsiqueira tbsiqueira merged commit 25b32cc into main Jul 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants