allow footer links that are not links

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
goauthentik · Jun 30, 2024 · bf0f715 · bf0f715
1 parent d927aae
commit bf0f715
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/authentik/brands/api.py b/authentik/brands/api.py
@@ -24,7 +24,7 @@
 class FooterLinkSerializer(PassiveSerializer):
     """Links returned in Config API"""
 
-    href = CharField(read_only=True)
+    href = CharField(read_only=True, allow_null=True)
     name = CharField(read_only=True)
 
 

diff --git a/schema.yml b/schema.yml
@@ -36634,6 +36634,7 @@ components:
         href:
           type: string
           readOnly: true
+          nullable: true
         name:
           type: string
           readOnly: true

diff --git a/web/src/flow/FlowExecutor.ts b/web/src/flow/FlowExecutor.ts
@@ -503,10 +503,13 @@ export class FlowExecutor extends Interface implements StageHost {
                                         <footer class="pf-c-login__footer">
                                             <ul class="pf-c-list pf-m-inline">
                                                 ${this.brand?.uiFooterLinks?.map((link) => {
+                                                    if (link.href) {
+                                                        return html`<li>
+                                                            <a href="${link.href}">${link.name}</a>
+                                                        </li>`;
+                                                    }
                                                     return html`<li>
-                                                        <a href="${link.href || ""}"
-                                                            >${link.name}</a
-                                                        >
+                                                        <span>${link.name}</span>
                                                     </li>`;
                                                 })}
                                                 <li>

diff --git a/website/docs/core/settings.md b/website/docs/core/settings.md
@@ -51,6 +51,8 @@ The setting can be used as follows:
 [{ "name": "Link Name", "href": "https://goauthentik.io" }]
 ```
 
+Starting with authentik 2024.6.1, the `href` attribute is optional, and this option can be used to add additional text to the flow executor pages.
+
 ### GDPR compliance
 
 When enabled, all the events caused by a user will be deleted upon the user's deletion. Defaults to `true`.