-
-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web, core: fix grammatical issue in stage bindings #10799
base: main
Are you sure you want to change the base?
Conversation
Global search & replace the phrase "...when the Stage is present to the user." with "...when the Stage is presented to the user." Because it's bad grammar. Since the source language phrase has been changed in all cases, it will have the same hash and the resulting translations will still be targeted the same.
authentik translations instructionsThanks for your pull request! authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically. |
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #10799 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 736 736
Lines 36542 36542
=======================================
+ Hits 33895 33896 +1
+ Misses 2647 2646 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I had no idea that this would involve more than one file, hahaha. Hilarious that I thought I could fix it. Thank you!
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-a86b9bbe11f7acb812e009cc629b422179c601b2
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s For arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-a86b9bbe11f7acb812e009cc629b422179c601b2-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s Afterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-a86b9bbe11f7acb812e009cc629b422179c601b2 For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-a86b9bbe11f7acb812e009cc629b422179c601b2-arm64 Afterwards, run the upgrade commands from the latest release notes. |
* main: (490 commits) website: latest migration to new structure (#11522) web: Fix css loading in unit tests, remove unneeded dot paths (#11629) website: bump docusaurus-theme-openapi-docs from 4.0.1 to 4.1.0 in /website (#11624) core, web: update translations (#11623) website: bump docusaurus-plugin-openapi-docs from 4.0.1 to 4.1.0 in /website (#11625) core: bump ruff from 0.6.8 to 0.6.9 (#11626) ci: require ci-web.build for merging (#11627) core: bump black from 24.8.0 to 24.10.0 (#11630) core: bump google-api-python-client from 2.147.0 to 2.148.0 (#11631) web: provide simple tables for API-less displays (#11028) core: bump goauthentik/fips-python from 3.12.6-slim-bookworm-fips-full to 3.12.7-slim-bookworm-fips-full (#11607) core: bump twilio from 9.3.2 to 9.3.3 (#11608) core: bump msgraph-sdk from 1.8.0 to 1.9.0 (#11609) web: small fixes for elements and forms (#11546) web: unify unit and end-to-end tests (#11598) web: audit and update package.json and associated test harness, with upgrade to WebdriverIO 9 (#11596) web: bump @spotlightjs/spotlight from 2.4.1 to 2.4.2 in /web in the sentry group across 1 directory (#11581) core: bump sentry-sdk from 2.14.0 to 2.15.0 (#11589) web: bump the rollup group across 2 directories with 4 updates (#11590) web: bump chromedriver from 129.0.1 to 129.0.2 in /tests/wdio (#11591) ...
Details
Global search & replace the phrase "...when the Stage is present to the user." with "...when the Stage is presented to the user."
Because it's bad grammar. Since the source language phrase has been changed in all cases, it will have the same hash and the resulting translations will still be targeted the same.
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)