Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test with postgres 17 #11577

Closed
wants to merge 1 commit into from
Closed

ci: test with postgres 17 #11577

wants to merge 1 commit into from

Conversation

4d62
Copy link
Contributor

@4d62 4d62 commented Oct 1, 2024

Details

This PR makes the main CI also test authentik with Postgres v17 which has been released a few days ago. I feel like this change is needed as I am sure a few people have already upgraded to v17 (myself included) and I'd like to make sure future authentik updates don't cause issues.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: 4d62 <github-user@sdko.org>
@4d62 4d62 requested a review from a team as a code owner October 1, 2024 01:18
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 495b531
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66fb4e040b095d0008c26544

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 495b531
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66fb4e04540ab50008b1ab08
😎 Deploy Preview https://deploy-preview-11577--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@4d62
Copy link
Contributor Author

4d62 commented Oct 1, 2024

PG 16 was tested while authentik ran on v12 so it could also continue the "test for future versions" type of thing

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (ec2d631) to head (495b531).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11577      +/-   ##
==========================================
+ Coverage   92.69%   92.75%   +0.06%     
==========================================
  Files         736      736              
  Lines       36542    36542              
==========================================
+ Hits        33871    33896      +25     
+ Misses       2671     2646      -25     
Flag Coverage Δ
e2e 49.25% <ø> (+0.10%) ⬆️
integration 24.98% <ø> (ø)
unit 90.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@4d62 4d62 marked this pull request as draft October 1, 2024 01:56
@4d62
Copy link
Contributor Author

4d62 commented Oct 1, 2024

the failing tests seem to originate from the same issue. I'm not familiar with the codebase so I wouldn't know where to start to fix the issue.

@rissson
Copy link
Member

rissson commented Oct 1, 2024

django_tenants probably doesn't support pg17 yet

@4d62
Copy link
Contributor Author

4d62 commented Oct 1, 2024

The source hasn't been updated in 2 months so I doubt it's gonna release soon

@4d62
Copy link
Contributor Author

4d62 commented Oct 1, 2024

If it works for PG 16 i think it's safe to assume it will work for 17. Pr was mostly to test of Ci broke or it was an easy fix

@4d62 4d62 closed this Oct 1, 2024
@4d62 4d62 deleted the patch-1 branch October 1, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants