-
-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: test with postgres 17 #11577
ci: test with postgres 17 #11577
Conversation
Signed-off-by: 4d62 <github-user@sdko.org>
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PG 16 was tested while authentik ran on v12 so it could also continue the "test for future versions" type of thing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11577 +/- ##
==========================================
+ Coverage 92.69% 92.75% +0.06%
==========================================
Files 736 736
Lines 36542 36542
==========================================
+ Hits 33871 33896 +25
+ Misses 2671 2646 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
the failing tests seem to originate from the same issue. I'm not familiar with the codebase so I wouldn't know where to start to fix the issue. |
django_tenants probably doesn't support pg17 yet |
The source hasn't been updated in 2 months so I doubt it's gonna release soon |
If it works for PG 16 i think it's safe to assume it will work for 17. Pr was mostly to test of Ci broke or it was an easy fix |
Details
This PR makes the main CI also test authentik with Postgres v17 which has been released a few days ago. I feel like this change is needed as I am sure a few people have already upgraded to v17 (myself included) and I'd like to make sure future authentik updates don't cause issues.
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)