Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outposts: Enhance config options for k8s outposts #7363

Merged
merged 9 commits into from
Mar 15, 2024

Conversation

PKizzle
Copy link
Contributor

@PKizzle PKizzle commented Oct 28, 2023

Details

Now by leaving kubernetes_ingress_secret_name empty no TLS section will be added to the ingress.
This is useful for ingress configurations where a default TLS secret is used if none is specified.

Additionally, kubernetes_service_ip_family_policy and kubernetes_service_ip_families add more detailed control over the created service i.e. when running Authentik in a dual-stack k8s cluster setup.

Todo

  • Add missing tests

@PKizzle PKizzle requested review from a team as code owners October 28, 2023 20:35
@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 0848f8b
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6567fad15142510008f0b9a4

@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 27922b6
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/6567c19c16c8b30007ac9356
😎 Deploy Preview https://deploy-preview-7363--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 3 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f559d25) 92.62% compared to head (0848f8b) 92.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7363      +/-   ##
==========================================
+ Coverage   92.62%   92.65%   +0.03%     
==========================================
  Files         588      588              
  Lines       29141    29143       +2     
==========================================
+ Hits        26991    27002      +11     
+ Misses       2150     2141       -9     
Flag Coverage Δ
e2e 50.73% <0.00%> (+0.03%) ⬆️
integration 25.95% <100.00%> (+<0.01%) ⬆️
unit 89.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu changed the title Enhance config options for k8s outposts outposts: Enhance config options for k8s outposts Nov 16, 2023
Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bugfixes for TLS and service type make sense, but for the other options kubernetes_json_patches should be used, we don't want to add specific config options for every single K8s option; see #5908 (comment)

This shall rather be configured using `kubernetes_json_patch` introduced with goauthentik#6319
@PKizzle PKizzle requested a review from BeryJu November 29, 2023 22:57
@PKizzle
Copy link
Contributor Author

PKizzle commented Nov 29, 2023

I have removed the IP family configuration options in favor of kubernetes_json_patches.

@PKizzle
Copy link
Contributor Author

PKizzle commented Nov 29, 2023

I was not able to find examples in the documentation for the kubernetes_json_patches feature just a link to a RFC document. Is this something that will be added in the future? The only example is currently available in the PR that introduced the feature.

@BeryJu
Copy link
Member

BeryJu commented Dec 2, 2023

I was not able to find examples in the documentation for the kubernetes_json_patches feature just a link to a RFC document. Is this something that will be added in the future? The only example is currently available in the PR that introduced the feature.

@PKizzle It should probably link to something like https://github.com/kubernetes-sigs/kustomize/blob/master/examples/jsonpatch.md which better demos how the JSON patches work (also feel free to add examples to the config if you want to)

@PKizzle
Copy link
Contributor Author

PKizzle commented Dec 3, 2023

I will update the documentation in another PR.

@PKizzle
Copy link
Contributor Author

PKizzle commented Feb 9, 2024

@BeryJu Is there anything I should change in this PR before it can get merged?

@BeryJu BeryJu merged commit 61b61ce into goauthentik:main Mar 15, 2024
65 checks passed
kensternberg-authentik added a commit that referenced this pull request Mar 18, 2024
* main: (31 commits)
  root: support redis username (#8935)
  core: bump black from 24.2.0 to 24.3.0 (#8945)
  web: bump the wdio group in /tests/wdio with 2 updates (#8939)
  web: bump the sentry group in /web with 1 update (#8941)
  website: bump postcss from 8.4.35 to 8.4.36 in /website (#8940)
  core: bump twilio from 9.0.1 to 9.0.2 (#8942)
  core: bump ruff from 0.3.2 to 0.3.3 (#8943)
  events: discard notification if user has empty email (#8938)
  ci: always run ci-main on branch pushes (#8950)
  core: bump goauthentik.io/api/v3 from 3.2024022.2 to 3.2024022.3 (#8946)
  website/docs: add new name "Microsft Entra ID" for Azure AD  (#8930)
  outposts: Enhance config options for k8s outposts (#7363)
  website/docs: add link to CRUD docs (#8925)
  web: bump API Client version (#8927)
  outpost: improved set secret answers for flow execution (#8013)
  stages/user_write: ensure user data is json-serializable (#8926)
  website/docs: update example ldapsearch commands (#8906)
  admin: Handle latest  version unknown in admin dashboard (#8858)
  core: bump coverage from 7.4.3 to 7.4.4 (#8917)
  core: bump urllib3 from 1.26.18 to 2.2.1 (#8918)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants