Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sources/ldap: clean-up certs written from db #7617

Merged
merged 2 commits into from
Nov 20, 2023
Merged

sources/ldap: clean-up certs written from db #7617

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
024c2fc
sources/ldap: clean-up certs written from db
ChandonPierre Nov 18, 2023
d92dd27
fix test when certificate is none
ChandonPierre Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions authentik/sources/ldap/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
"""authentik LDAP Models"""
from os import chmod
from os.path import dirname, exists
from shutil import rmtree
from ssl import CERT_REQUIRED
from tempfile import NamedTemporaryFile, mkdtemp
from typing import Optional
Expand Down Expand Up @@ -189,6 +191,11 @@
raise exc
server_kwargs["get_info"] = NONE
return self.connection(server, server_kwargs, connection_kwargs)
finally:
if connection.server.tls.certificate_file is not None and exists(
connection.server.tls.certificate_file
):
rmtree(dirname(connection.server.tls.certificate_file))

Check warning on line 198 in authentik/sources/ldap/models.py

View check run for this annotation

Codecov / codecov/patch

authentik/sources/ldap/models.py#L198 

Added line #L198 was not covered by tests
return RuntimeError("Failed to bind")

@property
Expand Down
Loading