Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix sources get icon naming #7674

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 21, 2023

Details

Just a small name change


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners November 21, 2023 20:30
Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 538b1bc
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/655d13804e273b0008fbb149

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (39458a1) 92.61% compared to head (538b1bc) 50.82%.
Report is 2 commits behind head on main.

Files Patch % Lines
authentik/sources/oauth/models.py 33.33% 2 Missing ⚠️
authentik/sources/plex/models.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7674       +/-   ##
===========================================
- Coverage   92.61%   50.82%   -41.80%     
===========================================
  Files         588      588               
  Lines       29140    29140               
===========================================
- Hits        26989    14809    -12180     
- Misses       2151    14331    +12180     
Flag Coverage Δ
e2e 49.19% <42.85%> (-1.50%) ⬇️
integration 25.93% <28.57%> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 68d266a into main Nov 21, 2023
57 of 61 checks passed
@BeryJu BeryJu deleted the core/fix-sources-get_icon-naming branch November 21, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant