Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages/email: prevent authentik emails from being marked as spam (also add text template support) #7949

Merged
merged 9 commits into from
Dec 21, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Dec 20, 2023

Details

closes #7940


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners December 20, 2023 15:54
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 85a73ee
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/658411311479f900082dd608

@authentik-automation
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 37.7%, saving 15.08 KB.

Filename Before After Improvement Visual comparison
website/docs/flow/stages/email/email_recovery.png 40.01 KB 24.93 KB -37.7% View diff

196 images did not require optimisation.

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 4bbfd39
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/65830e492fbb3f0008efd2f1
😎 Deploy Preview https://deploy-preview-7949--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 12 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 85a73ee
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/65841130a1be010009050ef8
😎 Deploy Preview https://deploy-preview-7949--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (256187e) 92.65% compared to head (4d623af) 92.65%.
Report is 4 commits behind head on main.

❗ Current head 4d623af differs from pull request most recent head 85a73ee. Consider uploading reports for the commit 85a73ee to get more accurate results

Files Patch % Lines
authentik/stages/email/utils.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7949      +/-   ##
==========================================
- Coverage   92.65%   92.65%   -0.01%     
==========================================
  Files         589      589              
  Lines       29271    29279       +8     
==========================================
+ Hits        27121    27127       +6     
- Misses       2150     2152       +2     
Flag Coverage Δ
e2e 50.65% <50.00%> (+<0.01%) ⬆️
integration 26.04% <7.14%> (-0.01%) ⬇️
unit 89.73% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rissson rissson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just being a bit RFC 3676 section 4.3 pedantic

authentik/stages/email/templates/email/password_reset.txt Outdated Show resolved Hide resolved
authentik/stages/email/templates/email/setup.txt Outdated Show resolved Hide resolved
website/docs/flow/stages/email/index.mdx Outdated Show resolved Hide resolved
BeryJu and others added 2 commits December 21, 2023 11:17
Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Jens L. <jens@beryju.org>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit ec8f2d4 into main Dec 21, 2023
64 of 66 checks passed
@BeryJu BeryJu deleted the stages/email/fix-spam-score branch December 21, 2023 13:32
kensternberg-authentik added a commit that referenced this pull request Dec 21, 2023
* main: (21 commits)
  web: bump API Client version (#7964)
  release: 2023.10.5
  web: bump API Client version (#7962)
  providers/scim: use lock for sync (#7948)
  stages/email: prevent authentik emails from being marked as spam (also add text template support) (#7949)
  website/docs: prepare 2023.10.5 (#7947)
  web: bump the sentry group in /web with 2 updates (#7955)
  web: bump the wdio group in /tests/wdio with 4 updates (#7957)
  core: bump goauthentik.io/api/v3 from 3.2023104.4 to 3.2023104.5 (#7958)
  web: bump API Client version (#7953)
  events: add ASN Database reader (#7793)
  translate: Updates for file web/xliff/en.xlf in fr (#7951)
  website/docs: add expression example for geoip (#7739)
  website: fix hosted API browser (#7946)
  core: bump github.com/redis/go-redis/v9 from 9.3.0 to 9.3.1 (#7942)
  web: bump the sentry group in /web with 2 updates (#7944)
  web: bump the storybook group in /web with 7 updates (#7945)
  core: bump goauthentik.io/api/v3 from 3.2023104.3 to 3.2023104.4 (#7943)
  providers/scim: set timeout based on page and page count (#7941)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7928)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Authentik emails trigger spam filters for both SpamAssassin and Microsoft
2 participants