Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enterprise/providers/rac: add alert that enterprise is required for RAC #8057

Merged

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 4, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners January 4, 2024 14:27
Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 3721509
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6596c06a8f8eb90008d5a902
😎 Deploy Preview https://deploy-preview-8057--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b93ad86) 92.35% compared to head (3721509) 50.73%.

Files Patch % Lines
authentik/enterprise/api.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8057       +/-   ##
===========================================
- Coverage   92.35%   50.73%   -41.62%     
===========================================
  Files         608      608               
  Lines       30160    30174       +14     
===========================================
- Hits        27853    15309    -12544     
- Misses       2307    14865    +12558     
Flag Coverage Δ
e2e 49.11% <77.77%> (-1.50%) ⬇️
integration 26.44% <61.11%> (+0.19%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-enterprise-providers-rac-prevent-rac-save-without-enterprise-1704379607-3721509
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-enterprise-providers-rac-prevent-rac-save-without-enterprise-1704379607-3721509-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-enterprise-providers-rac-prevent-rac-save-without-enterprise-1704379607-3721509

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-enterprise-providers-rac-prevent-rac-save-without-enterprise-1704379607-3721509-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 116ac30 into main Jan 4, 2024
69 of 71 checks passed
@BeryJu BeryJu deleted the enterprise/providers/rac/prevent-rac-save-without-enterprise branch January 4, 2024 15:18
kensternberg-authentik added a commit that referenced this pull request Jan 4, 2024
* main:
  website/docs: add link to our example flows (#8052)
  providers/oauth2: offline access (#8026)
  web: bump API Client version (#8059)
  Update index.md (#8056)
  enterprise/providers/rac: add option to limit concurrent connections to endpoint (#8053)
  web: bump API Client version (#8058)
  enterprise/providers/rac: add alert that enterprise is required for RAC (#8057)
  enterprise/providers/rac: create authorize_application event when creating token (#8050)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant