Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/oauth: fix azure_ad user_id and add test and fallback #8146

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 12, 2024

Details

closes #8131


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner January 12, 2024 18:23
Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 5c1e3d2
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65a183a02bda20000868a526

@BeryJu
Copy link
Member Author

BeryJu commented Jan 12, 2024

/cherry-pick version-2023.10

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f70a86) 92.32% compared to head (5c1e3d2) 92.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8146      +/-   ##
==========================================
- Coverage   92.32%   92.32%   -0.01%     
==========================================
  Files         608      608              
  Lines       30246    30250       +4     
==========================================
+ Hits        27924    27927       +3     
- Misses       2322     2323       +1     
Flag Coverage Δ
e2e 50.58% <25.00%> (-0.02%) ⬇️
integration 26.40% <25.00%> (-0.01%) ⬇️
unit 89.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-oauth-fix-azure-ad-user-id-fallback-1705085901-5c1e3d2
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-oauth-fix-azure-ad-user-id-fallback-1705085901-5c1e3d2-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-oauth-fix-azure-ad-user-id-fallback-1705085901-5c1e3d2

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-oauth-fix-azure-ad-user-id-fallback-1705085901-5c1e3d2-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit e51f900 into main Jan 12, 2024
70 checks passed
@BeryJu BeryJu deleted the sources/oauth/fix-azure-ad-user-id-fallback branch January 12, 2024 19:48
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 12, 2024
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2023.10.6 - "Please select a username" after Azure AD login
1 participant