Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: add solve gitea group does not take effect #8413

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

yidaqiang
Copy link
Contributor

When config my gitea Follow step 4,I find new user create by authentik flow don't have group role.

I debug gitea found out why. gitea ENABLE_AUTO_REGISTRATION is false by default. So new user is create by gitab default method showLinkingLogin.
https://github.com/go-gitea/gitea/blob/6992ef98fc227a60cf06e0a06b9ae2492b3d61be/routers/web/auth/oauth.go#L953
https://docs.gitea.com/administration/config-cheat-sheet?_highlight=enable_auto_registration#oauth2-client-oauth2_client

We need to remind this gitea configuration item——ENABLE_AUTO_REGISTRATION: true.

@yidaqiang yidaqiang requested a review from a team as a code owner February 5, 2024 10:20
Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 11dfe9a
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65c0b68cd255090008a7d692

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 11dfe9a
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/65c0b68c54c4e1000857b9a3
😎 Deploy Preview https://deploy-preview-8413--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tanberry
Copy link
Contributor

Thank you @yidaqiang for adding this helpful contribution!

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (709436a) 92.26% compared to head (11dfe9a) 92.26%.
Report is 167 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8413   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files         626      626           
  Lines       30996    30996           
=======================================
+ Hits        28599    28600    +1     
+ Misses       2397     2396    -1     
Flag Coverage Δ
e2e 50.64% <ø> (+<0.01%) ⬆️
integration 25.99% <ø> (ø)
unit 89.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yidaqiang
Copy link
Contributor Author

Thank you!

Also Thanks for your beautiful work.

@tanberry tanberry merged commit 868229a into goauthentik:main Feb 26, 2024
69 of 70 checks passed
kensternberg-authentik added a commit that referenced this pull request Feb 27, 2024
* main: (75 commits)
  Add missing commas, correction of spelling errors (#8680)
  website/docs: Add documentation for Glitchtip (#8182)
  website: add solve gitea group does not take effect (#8413)
  enterprise: fix read_only activating when no license is installed (#8697)
  core: fix blueprint export (#8695)
  web: bump the sentry group in /web with 1 update (#8687)
  web: bump yaml from 2.3.4 to 2.4.0 in /web (#8689)
  web: bump the eslint group in /web with 1 update (#8688)
  core: bump pytest from 8.0.1 to 8.0.2 (#8693)
  website: bump @types/react from 18.2.57 to 18.2.58 in /website (#8690)
  web: bump the eslint group in /tests/wdio with 1 update (#8691)
  core: bump sentry-sdk from 1.40.4 to 1.40.5 (#8692)
  core: bump coverage from 7.4.1 to 7.4.3 (#8694)
  providers/oauth2: fix inconsistent `sub` value when setting via mapping (#8677)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8678)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8679)
  core, web: update translations (#8672)
  root: fix config loading after refactor during ruff migration (#8674)
  root: early spring clean for linting (#8498)
  website/integrations: multiple integration edits (#7923)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants