Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blueprints: use reconcile decorator instead of relying on function name prefix #8483

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Feb 12, 2024

Details

closes #7852

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

…me prefix

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from rissson February 12, 2024 12:09
@BeryJu BeryJu requested a review from a team as a code owner February 12, 2024 12:09
Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 0d2c63e
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65ca0a60aad0710008aad5c8

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-blueprints-attempt-cleaner-reconcile-1707741881-0d2c63e
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-blueprints-attempt-cleaner-reconcile-1707741881-0d2c63e-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-blueprints-attempt-cleaner-reconcile-1707741881-0d2c63e

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-blueprints-attempt-cleaner-reconcile-1707741881-0d2c63e-arm64

Afterwards, run the upgrade commands from the latest release notes.

Copy link
Member

@rissson rissson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but let's merge after 2024.2

@BeryJu BeryJu merged commit 341d866 into main Feb 23, 2024
69 checks passed
@BeryJu BeryJu deleted the blueprints/attempt-cleaner-reconcile branch February 23, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blueprints: find another way to run reconcile than with dir()
2 participants