Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: fix broken locale compile #9095

Merged
merged 2 commits into from
Apr 1, 2024
Merged

web: fix broken locale compile #9095

merged 2 commits into from
Apr 1, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 1, 2024

Details

Seems like https://github.com/goauthentik/authentik/actions/runs/8501811472/job/23285139087 has been broken for a bit due to some duplicate strings

Fix the duplicate strings, remove a leftover TODO


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners April 1, 2024 23:04
Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 0d2264d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/660b3f8373cd300007162b5e

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 0d2264d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/660b3f8327542e00082f9d7b
😎 Deploy Preview https://deploy-preview-9095--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 1, 2024

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner April 1, 2024 23:13
@BeryJu BeryJu merged commit 6302ff2 into main Apr 1, 2024
62 of 63 checks passed
@BeryJu BeryJu deleted the web/fix-locales branch April 1, 2024 23:30
kensternberg-authentik added a commit that referenced this pull request Apr 4, 2024
* main:
  root: fix missing imports after #9081 (#9106)
  root: move database calls from ready() to dedicated startup signal (#9081)
  web: fix console log leftover (#9096)
  web: bump the eslint group in /web with 2 updates (#9098)
  core: bump twilio from 9.0.2 to 9.0.3 (#9103)
  web: bump the eslint group in /tests/wdio with 2 updates (#9099)
  core: bump drf-spectacular from 0.27.1 to 0.27.2 (#9100)
  core: bump django-model-utils from 4.4.0 to 4.5.0 (#9101)
  core: bump ruff from 0.3.4 to 0.3.5 (#9102)
  website/docs:  update notes on SECRET_KEY (#9091)
  web: fix broken locale compile (#9095)
  website/integrations: add outline knowledge base (#8786)
  website/docs: fix typo (#9082)
  website/docs: email stage: fix example translation error (#9048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant