-
-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: provide better feedback on Application Library page about search results #9386
Merged
kensternberg-authentik
merged 42 commits into
main
from
web/enhance/better-empty-app-search
Jun 26, 2024
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
3146e5a
web: fix esbuild issue with style sheets
kensternberg-authentik fe52f44
Merge branch 'main' into dev
kensternberg-authentik e505f27
Merge branch 'main' into dev
kensternberg-authentik 5090621
Merge branch 'main' into dev
kensternberg-authentik 035bda4
Merge branch 'main' into dev
kensternberg-authentik 2d0117d
Merge branch 'main' into dev
kensternberg-authentik 22cb5b7
Merge branch 'main' into dev
kensternberg-authentik 8b4e036
Merge branch 'main' into dev
kensternberg-authentik db96e1a
Merge branch 'main' into dev
kensternberg-authentik 8946b81
Merge branch 'main' into dev
kensternberg-authentik 30beca9
Merge branch 'main' into dev
kensternberg-authentik 5d84082
Merge branch 'main' into dev
kensternberg-authentik a7e3dca
Merge branch 'main' into dev
kensternberg-authentik 2d254d6
Merge branch 'main' into dev
kensternberg-authentik 3f95020
Merge branch 'main' into dev
kensternberg-authentik a056703
Merge branch 'main' into dev
kensternberg-authentik fc00bde
Merge branch 'main' into dev
kensternberg-authentik 7123b2c
Merge branch 'main' into dev
kensternberg-authentik 5d4c380
Merge branch 'main' into dev
kensternberg-authentik 66cefcc
Merge branch 'main' into dev
kensternberg-authentik 875fc5c
Merge branch 'main' into dev
kensternberg-authentik c84be1d
Merge branch 'main' into dev
kensternberg-authentik b08dcc2
Merge branch 'main' into dev
kensternberg-authentik 272fdc5
Merge branch 'main' into dev
kensternberg-authentik 23665d1
Merge branch 'main' into dev
kensternberg-authentik cacdf64
Merge branch 'main' into dev
kensternberg-authentik 085debf
Merge branch 'main' into dev
kensternberg-authentik f19ed14
Merge branch 'main' into dev
kensternberg-authentik ac4ba5d
Merge branch 'main' into dev
kensternberg-authentik 98503f6
Merge branch 'main' into dev
kensternberg-authentik 2d94b16
Merge branch 'main' into dev
kensternberg-authentik c01045d
web: improve state management of Fuze application search
kensternberg-authentik 34de6bf
Merge branch 'main' into dev
kensternberg-authentik ca42506
Merge branch 'main' into dev
kensternberg-authentik 2a96900
Merge branch 'main' into dev
kensternberg-authentik 9acebec
Merge branch 'main' into dev
kensternberg-authentik 8248163
Merge branch 'main' into dev
kensternberg-authentik 7cb0cd4
Merge branch 'dev' into web/enhance/better-empty-app-search
kensternberg-authentik a3251d8
Merge branch 'main' into web/enhance/better-empty-app-search
kensternberg-authentik baf36c2
web: updated the improved search to Google's Lit standards for events.
kensternberg-authentik 01320f0
Merge branch 'main' into web/enhance/better-empty-app-search
kensternberg-authentik db67d36
Merge branch 'main' into web/enhance/better-empty-app-search
kensternberg-authentik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
web/src/user/LibraryPage/ak-library-application-search-empty.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import { AKElement } from "@goauthentik/elements/Base"; | ||
|
||
import { msg } from "@lit/localize"; | ||
import { html } from "lit"; | ||
import { customElement } from "lit/decorators.js"; | ||
|
||
import PFContent from "@patternfly/patternfly/components/Content/content.css"; | ||
import PFEmptyState from "@patternfly/patternfly/components/EmptyState/empty-state.css"; | ||
import PFBase from "@patternfly/patternfly/patternfly-base.css"; | ||
import PFSpacing from "@patternfly/patternfly/utilities/Spacing/spacing.css"; | ||
|
||
/** | ||
* Library Page Application List Empty | ||
* | ||
* Display a message if there are no applications defined in the current instance. If the user is an | ||
* administrator, provide a link to the "Create a new application" page. | ||
*/ | ||
|
||
@customElement("ak-library-application-search-empty") | ||
export class LibraryPageApplicationSearchEmpty extends AKElement { | ||
static get styles() { | ||
return [PFBase, PFEmptyState, PFContent, PFSpacing]; | ||
} | ||
|
||
render() { | ||
return html` <div class="pf-c-empty-state pf-m-full-height"> | ||
<div class="pf-c-empty-state__content"> | ||
<i class="fas fa-cubes pf-c-empty-state__icon" aria-hidden="true"></i> | ||
<h1 class="pf-c-title pf-m-lg">${msg("Search returned no results.")}</h1> | ||
</div> | ||
</div>`; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be we importing these files are
.js
? If anything we probably shouldn't for consistencyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The standard is quickly becoming "If it's going to be a JS file, always use a .js extension." I'd like to keep doing that from now on. Typescript has extensive documentation on it. Browser stuff should be ES2020 and beyond.