Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/oauth: ensure all UI sources return a valid source #9401

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 24, 2024

Details

closes #9402


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners April 24, 2024 17:41
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 0a08fcb
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66296db26165a50009aa69fc

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 0a08fcb
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66296db25c9df00008204d45

@BeryJu
Copy link
Member Author

BeryJu commented Apr 24, 2024

/cherry-pick version 2024.4

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.39%. Comparing base (b6171aa) to head (0a08fcb).
Report is 1 commits behind head on main.

Files Patch % Lines
authentik/stages/identification/stage.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9401      +/-   ##
==========================================
- Coverage   92.39%   92.39%   -0.01%     
==========================================
  Files         667      668       +1     
  Lines       32644    32669      +25     
==========================================
+ Hits        30163    30186      +23     
- Misses       2481     2483       +2     
Flag Coverage Δ
e2e 50.65% <4.00%> (-0.06%) ⬇️
integration 26.02% <0.00%> (-0.02%) ⬇️
unit 89.69% <96.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 24, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-0a08fcbb0f2b85a7b85134a95e5f7bba7e732392
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-0a08fcbb0f2b85a7b85134a95e5f7bba7e732392-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-0a08fcbb0f2b85a7b85134a95e5f7bba7e732392

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-0a08fcbb0f2b85a7b85134a95e5f7bba7e732392-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu changed the title web/admin: prevent selection of inbuilt source in identification stage sources/oauth: ensure all UI sources return a valid source Apr 24, 2024
@BeryJu
Copy link
Member Author

BeryJu commented Apr 24, 2024

/cherry-pick version-2024.4

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit 80af26e into main Apr 24, 2024
65 checks passed
@BeryJu BeryJu deleted the web/admin/fix-ident-stage-source branch April 24, 2024 20:55
@BeryJu
Copy link
Member Author

BeryJu commented Apr 24, 2024

/cherry-pick version-2024.4

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 24, 2024
* web/admin: prevent selection of inbuilt source in identification stage

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix apple source

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* also fix plex challenge

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Apr 24, 2024
#9401) (#9406)

sources/oauth: ensure all UI sources return a valid source (#9401)

* web/admin: prevent selection of inbuilt source in identification stage



* fix apple source



* also fix plex challenge



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Apr 30, 2024
* main:
  web: clean up some repetitive types (#9241)
  core: fix logic for token expiration (#9426)
  ci: fix ci pipeline (#9427)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9424)
  web: Add resolved and integrity fields back to package-lock.json (#9419)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9407)
  stages/identification: don't check source component (#9410)
  core: bump selenium from 4.19.0 to 4.20.0 (#9411)
  core: bump black from 24.4.0 to 24.4.1 (#9412)
  ci: bump golangci/golangci-lint-action from 4 to 5 (#9413)
  core: bump goauthentik.io/api/v3 from 3.2024023.2 to 3.2024040.1 (#9414)
  web: bump @sentry/browser from 7.112.1 to 7.112.2 in /web in the sentry group (#9416)
  sources/oauth: ensure all UI sources return a valid source (#9401)
  web: markdown: display markdown even when frontmatter is missing (#9404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't login with Apple OAuth after update to 2024.4.0
1 participant