Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating packr #43

Merged
merged 4 commits into from
Dec 17, 2021
Merged

Deprecating packr #43

merged 4 commits into from
Dec 17, 2021

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Nov 23, 2021

As a part of gobuffalo/buffalo#2152, modernize it.

  • updated gobuffalo family module dependencies
  • migrated from packr to go:embed
  • fixed command set and updated template
  • fixed Github action files: release versioning and test against recent Go versions

@fasmat
Copy link
Member

fasmat commented Nov 23, 2021

Looks good to me

@sio4 sio4 requested a review from a team November 29, 2021 10:43
@sio4 sio4 self-assigned this Nov 29, 2021
@sio4 sio4 added the process process or management stuffs label Nov 29, 2021
@sio4 sio4 marked this pull request as ready for review November 29, 2021 10:48
@sio4
Copy link
Member Author

sio4 commented Dec 16, 2021

@paganotoni can you please merge this?

genny/auth/templates/actions/auth.go.tmpl Outdated Show resolved Hide resolved
@sio4 sio4 merged commit 04d1ed3 into gobuffalo:master Dec 17, 2021
@sio4 sio4 deleted the deprecating-packr branch May 14, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process process or management stuffs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants