Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

PROPOSAL: Fail on npm/node issues during buffalo new #1368

Closed
markbates opened this issue Oct 13, 2018 · 0 comments
Closed

PROPOSAL: Fail on npm/node issues during buffalo new #1368

markbates opened this issue Oct 13, 2018 · 0 comments
Assignees
Labels
breaking change This feature / fix introduces breaking changes proposal A suggestion for a change, feature, enhancement, etc
Milestone

Comments

@markbates
Copy link
Member

The current behavior of buffalo new is to try and install the Webpack asset pipeline. If this fails, Buffalo falls back to trying to install the various missing pieces, but should all of that still fails, Buffalo issues a warning and moves on.

I argue that this causes many users bizarre and often confusing errors down the line that are difficult to track down.

I propose, that instead of a warning, we error instead. This raise the issue with the developer more directly and will the give them the chance to either a) install the proper missing/broken Webpack related infrastructure or b) let the re-run the command with the --skip-weback flag to build an application without the need for those tools.

@markbates markbates added breaking change This feature / fix introduces breaking changes proposal A suggestion for a change, feature, enhancement, etc labels Oct 13, 2018
@markbates markbates added this to the v0.13.1 milestone Oct 13, 2018
@markbates markbates self-assigned this Oct 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This feature / fix introduces breaking changes proposal A suggestion for a change, feature, enhancement, etc
Projects
None yet
Development

No branches or pull requests

1 participant